Skip to content

Commit

Permalink
Remove @unstable from a few vertx API which have proven to be stable
Browse files Browse the repository at this point in the history
  • Loading branch information
vietj committed Oct 27, 2024
1 parent a251e51 commit fa57951
Show file tree
Hide file tree
Showing 4 changed files with 0 additions and 16 deletions.
7 changes: 0 additions & 7 deletions vertx-core/src/main/java/io/vertx/core/file/AsyncFile.java
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,6 @@

import io.vertx.codegen.annotations.Fluent;
import io.vertx.codegen.annotations.Nullable;
import io.vertx.codegen.annotations.Unstable;
import io.vertx.codegen.annotations.VertxGen;
import io.vertx.core.Future;
import io.vertx.core.Handler;
Expand Down Expand Up @@ -174,7 +173,6 @@ public interface AsyncFile extends ReadStream<Buffer>, WriteStream<Buffer> {
*
* @return the lock if it can be acquired immediately, otherwise {@code null}
*/
@Unstable
default @Nullable AsyncFileLock tryLock() {
return tryLock(0, Long.MAX_VALUE, false);
}
Expand All @@ -187,15 +185,13 @@ public interface AsyncFile extends ReadStream<Buffer>, WriteStream<Buffer> {
* @param shared whether the lock should be shared
* @return the lock if it can be acquired immediately, otherwise {@code null}
*/
@Unstable
@Nullable AsyncFileLock tryLock(long position, long size, boolean shared);

/**
* Acquire a non-shared lock on the entire file.
*
* @return a future indicating the completion of this operation
*/
@Unstable
default Future<AsyncFileLock> lock() {
return lock(0, Long.MAX_VALUE, false);
}
Expand All @@ -208,7 +204,6 @@ default Future<AsyncFileLock> lock() {
* @param shared whether the lock should be shared
* @return a future indicating the completion of this operation
*/
@Unstable
Future<AsyncFileLock> lock(long position, long size, boolean shared);

/**
Expand All @@ -222,7 +217,6 @@ default Future<AsyncFileLock> lock() {
* @param block the code block called after lock acquisition
* @return the future returned by the {@code block}
*/
@Unstable
default <T> Future<T> withLock(Supplier<Future<T>> block) {
return withLock(0, Long.MAX_VALUE, false, block);
}
Expand All @@ -241,7 +235,6 @@ default <T> Future<T> withLock(Supplier<Future<T>> block) {
* @param block the code block called after lock acquisition
* @return the future returned by the {@code block}
*/
@Unstable
default <T> Future<T> withLock(long position, long size, boolean shared, Supplier<Future<T>> block) {
return lock(position, size, shared)
.compose(lock -> {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,6 @@
import io.netty.handler.logging.ByteBufFormat;
import io.vertx.codegen.annotations.DataObject;
import io.vertx.codegen.annotations.GenIgnore;
import io.vertx.codegen.annotations.Unstable;
import io.vertx.codegen.json.annotations.JsonGen;
import io.vertx.core.Handler;
import io.vertx.core.buffer.Buffer;
Expand Down Expand Up @@ -591,7 +590,6 @@ public HttpServerOptions setCompressionLevel(int compressionLevel) {
/**
* @return the list of compressor to use
*/
@Unstable
public List<CompressionOptions> getCompressors() {
return compressors;
}
Expand All @@ -602,7 +600,6 @@ public List<CompressionOptions> getCompressors() {
* @see #setCompressors(List)
* @return a reference to this, so the API can be used fluently
*/
@Unstable
public HttpServerOptions addCompressor(CompressionOptions compressor) {
if (compressors == null) {
compressors = new ArrayList<>();
Expand All @@ -619,7 +616,6 @@ public HttpServerOptions addCompressor(CompressionOptions compressor) {
* @param compressors the list of compressors
* @return a reference to this, so the API can be used fluently
*/
@Unstable
public HttpServerOptions setCompressors(List<CompressionOptions> compressors) {
this.compressors = compressors;
return this;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,6 @@
package io.vertx.core.net;

import io.vertx.codegen.annotations.DataObject;
import io.vertx.codegen.annotations.Unstable;
import io.vertx.codegen.json.annotations.JsonGen;
import io.vertx.core.impl.Arguments;
import io.vertx.core.json.JsonObject;
Expand Down Expand Up @@ -206,7 +205,6 @@ public boolean getLogActivity() {
/**
* @return Netty's logging handler's data format.
*/
@Unstable
public ByteBufFormat getActivityLogDataFormat() {
return activityLogDataFormat;
}
Expand All @@ -228,7 +226,6 @@ public NetworkOptions setLogActivity(boolean logActivity) {
* @param activityLogDataFormat the format to use
* @return a reference to this, so the API can be used fluently
*/
@Unstable
public NetworkOptions setActivityLogDataFormat(ByteBufFormat activityLogDataFormat) {
this.activityLogDataFormat = activityLogDataFormat;
return this;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -16,14 +16,12 @@

import io.netty.util.internal.ObjectUtil;
import io.vertx.codegen.annotations.DataObject;
import io.vertx.codegen.annotations.Unstable;
import io.vertx.codegen.json.annotations.JsonGen;
import io.vertx.core.json.JsonObject;

/**
* Options describing how {@link io.netty.handler.traffic.GlobalTrafficShapingHandler} will handle traffic shaping.
*/
@Unstable
@DataObject
@JsonGen(publicConverter = false)
public class TrafficShapingOptions {
Expand Down

0 comments on commit fa57951

Please sign in to comment.