Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add features to hide Zenoh unstable #91

Merged
merged 2 commits into from
Nov 16, 2024
Merged

Add features to hide Zenoh unstable #91

merged 2 commits into from
Nov 16, 2024

Conversation

evshary
Copy link
Contributor

@evshary evshary commented Nov 15, 2024

Deal with #90

@evshary evshary requested review from PLeVasseur and sophokles73 and removed request for PLeVasseur November 15, 2024 03:50
@sophokles73 sophokles73 added the enhancement New feature or request label Nov 15, 2024
sophokles73
sophokles73 approved these changes Nov 15, 2024
View reviewed changes
Copy link
Contributor

@sophokles73 sophokles73 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IMHO it would be good to also document the supported feature(s) in the doc comments of lib.rs so that it is included on docs.rs

PLeVasseur
PLeVasseur approved these changes Nov 15, 2024
View reviewed changes
Copy link
Contributor

@PLeVasseur PLeVasseur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Can you cut a release so that I can try to integrate this into up-streamer-rust?

@evshary
Copy link
Contributor Author

evshary commented Nov 16, 2024 •
edited
Loading

IMHO it would be good to also document the supported feature(s) in the doc comments of lib.rs so that it is included on docs.rs

@sophokles73 Good idea

Can you cut a release so that I can try to integrate this into up-streamer-rust?

@PLeVasseur Sure thing

@evshary evshary merged commit 5817a6d into eclipse-uprotocol:main Nov 16, 2024
7 checks passed
@evshary evshary deleted the add_features branch November 16, 2024 01:55
@evshary evshary linked an issue Nov 16, 2024 that may be closed by this pull request
Hide Zenoh unstable behind the feature #90
Closed
@evshary evshary mentioned this pull request Nov 16, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PLeVasseur PLeVasseur PLeVasseur approved these changes

@sophokles73 sophokles73 sophokles73 approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Hide Zenoh unstable behind the feature
3 participants
@evshary @sophokles73 @PLeVasseur