Fix CI issues #5
Conversation
Signed-off-by: ChenYing Kuo <[email protected]>
Signed-off-by: ChenYing Kuo <[email protected]>
Signed-off-by: ChenYing Kuo <[email protected]>
Signed-off-by: ChenYing Kuo <[email protected]>
Signed-off-by: ChenYing Kuo <[email protected]>
|
Since the PR is merged, this can be reviewed |
| @@ -20,5 +20,5 @@ log = "0.4.17" | |||
| prost = "0.12" | |||
| prost-types = "0.12" | |||
| protobuf = { version = "3.3" } | |||
| up-rust = { git = "https://github.com/eclipse-uprotocol/up-rust", branch = "main" } | |||
| up-rust = { git = "https://github.com/eclipse-uprotocol/up-rust", rev = "68c8a1d94f0006daf4ba135c9cbbfddcd793108d" } | |||
There was a problem hiding this comment.
Ah okay, and then if there's a tag, we can use that instead. I'm always super impressed by Rust tooling. Using a git tag has been supported since 2014 🙂
| UStatus::fail_with_code(UCode::INVALID_ARGUMENT, "Wrong authority") | ||
| })?; | ||
| } | ||
| let buf: Vec<u8> = authority.try_into().map_err(|_| { |
| } | ||
|
|
||
| // The UURI format should be "upr/<UAuthority id or ip>/<the rest of remote UUri>" or "upl/<local UUri>" | ||
| fn to_zenoh_key_string(uri: &UUri) -> Result<String, UStatus> { | ||
| if uri.authority.is_some() && uri.entity.is_none() && uri.resource.is_none() { | ||
| Ok(String::from("upr/") + &UPClientZenoh::get_uauth_from_uuri(uri)? + "/**") | ||
| } else { | ||
| let micro_uuri = MicroUriSerializer::serialize(uri).map_err(|_| { | ||
| let micro_uuri: Vec<u8> = uri.try_into().map_err(|_| { |
| let mut uattributes = | ||
| UAttributesBuilder::request(UPriority::UPRIORITY_CS4, topic.clone(), 255).build(); | ||
| // TODO: How to create the source address for Response | ||
| let uuid_builder = UUIDBuilder::new(); |
There was a problem hiding this comment.
I think this RPC flow still needs some thought though.
We should not be creating a new UUIDBuilder here and getting the reqid from it. I believe this is where the UUIDBuilder that's been constructed already for the uE sending the request should be used.
As is stated over here in the UUID spec, the rand_b portion of the UUID is used to uniquely identify the uE, thus it should be "stable" and thus we should use the UUIDBuilder already associated with this uE.
I suppose that may mean that on construction, you'd need to construct a UUIDBuilder and then use it within RpcClient::invoke_method().
WDYT?
As titled, the PR is to fix the lint and build issue.
But we need to wait for the following PR to be merged.
eclipse-uprotocol/up-rust#52