[#33] No longer supply stlib paths #34
Conversation
|
Hey @dmacattack -- thanks for the contribution! Is there any way to incorporate this into the CI to ensure that it's used as a part of it and validated? |
dmacattack
force-pushed
the
add-build-script
branch
5 times, most recently
from
6f9d7cd to
d81755f
Compare
dmacattack
force-pushed
the
add-build-script
branch
from
8d4880b to
23ae41b
Compare
|
@PLeVasseur Opening this PR. seems like obtain_and_build_vsomeip is failing just like it did on PR #35 but the build_env script is working, and the tests are updated accordingly issue #37 created |
dmacattack
force-pushed
the
add-build-script
branch
from
23ae41b to
c695cc8
Compare
dmacattack
force-pushed
the
add-build-script
branch
4 times, most recently
from
24a1781 to
f236fc9
Compare
|
I went back in the history of this project and found the ones that succeeded were in fact ubuntu 22.04. I dont have 24 installed, but I would bet vsomeip doesnt build on it either (not just a workflow issue). |
|
Hey @dmacattack -- thanks for troubleshooting! I'll put some time aside to review :) |
There was a problem hiding this comment.
Hey @dmacattack -- thanks for doing the troubleshooting around Boost in this PR too!
I left a few suggestions. Could you take a look?
* add buildenv.sh & update workflows to set the c++ paths * update READMEs accordingly * decrease test iterations for efficient tests * fix runner version to ubuntu 22.04 * add workflow build dependencies Implements [eclipse-uprotocol#33, eclipse-uprotocol#37]
dmacattack
force-pushed
the
add-build-script
branch
from
66bafd7 to
21019ff
Compare
closes #33
closes #37