ftrace: improve binary parser speed by optimizing I/O #31
Conversation
fabrizioiannetti
force-pushed
the
faster_ftrace_dat_parse
branch
2 times, most recently
from
8838680
to
352b4a1
Compare
|
This is still WIP. I know your approach will work, we didn't have time to get it done. (We start by coding defensively, then optimize) This will be great, please remove the printlns though ;) |
fabrizioiannetti
force-pushed
the
faster_ftrace_dat_parse
branch
from
352b4a1
to
b4230f4
Compare
missed that one :-), removed the println. |
fabrizioiannetti
force-pushed
the
faster_ftrace_dat_parse
branch
from
b4230f4
to
eff5a6f
Compare
fabrizioiannetti
changed the title
|
Hi, is something missing in the PR for review? |
| super.dispose(); | ||
| // release (indirect) references to mem-mapped file buffers so that tracecompass | ||
| // can garbage-collect them and unlock the file (e.g. if the user wants to delete it) | ||
| fStrategy = null; |
There was a problem hiding this comment.
There should be a dispose method in the IBinaryFTraceStrategy that does this for the BinaryFTraceV6Strategy.
There was a problem hiding this comment.
Thanks for the review, done: I moved the clearing of the reference to the strategy class.
I did not go deeper in the structure, let me know if it's good like this.
There was a problem hiding this comment.
seems I broke something with that, need to look into it :-)
There was a problem hiding this comment.
The change is perfect, it just needs to pass the test now :)
There was a problem hiding this comment.
Seems like it needs a null check before calling dispose().
There was a problem hiding this comment.
Thanks for the hint! Took me a while to find the right logs
fabrizioiannetti
force-pushed
the
faster_ftrace_dat_parse
branch
from
eff5a6f
to
6df91ee
Compare
* mmap the whole file for faster parsing * re-use the same mapping to read events Signed-off-by: Fabrizio Iannetti <[email protected]>
fabrizioiannetti
force-pushed
the
faster_ftrace_dat_parse
branch
from
6df91ee
to
6cb47a5
Compare
MatthewKhouzam
merged commit 286f29e
into
eclipse-tracecompass-incubator:master
|
@fabrizioiannetti thank you so much for the contribution! |
on my (oldish) laptop with ubuntu 24.04 the file is parsed an order of magnitude faster
on a recent windows laptop I measured two orders of magnitude faster