Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reactivate withTrustedRoots by default in HTTP binding #198

Merged
merged 2 commits into from
Nov 4, 2024
Merged

Conversation

JKRhb
Copy link
Member

@JKRhb JKRhb commented Nov 4, 2024

While #194 introduced the ability to set custom trusted certificates for the security contexts that are being created from the HTTP binding, it accidentally let the HTTP clients not use the default trusted root certificates of the underlying platform anymore. This PR fixes the issue by introducing a new config parameter, partly by using it in an appropriate place.

@JKRhb JKRhb enabled auto-merge November 4, 2024 21:47
@codecov-commenter
Copy link

codecov-commenter commented Nov 4, 2024

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 63.45%. Comparing base (a3156ac) to head (e7dc1fe).
Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
lib/src/binding_http/http_client.dart 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #198      +/-   ##
==========================================
- Coverage   63.47%   63.45%   -0.03%     
==========================================
  Files          78       78              
  Lines        2300     2301       +1     
==========================================
  Hits         1460     1460              
- Misses        840      841       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@JKRhb JKRhb merged commit 3f40b8a into main Nov 4, 2024
5 checks passed
@JKRhb JKRhb deleted the trusted-roots branch November 4, 2024 21:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants