-
Notifications
You must be signed in to change notification settings - Fork 98
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create new endpoints that allow to add/update/edit project with dependency network #2615
Merged
heliocastro
merged 8 commits into
eclipse-sw360:main
from
toshiba:release/feat_rest-dependency-network-edit-page
Nov 19, 2024
Merged
Create new endpoints that allow to add/update/edit project with dependency network #2615
heliocastro
merged 8 commits into
eclipse-sw360:main
from
toshiba:release/feat_rest-dependency-network-edit-page
Nov 19, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hoangnt2
added
needs code review
needs general test
This is general testing, meaning that there is no org specific issue to check for
REST
New-UI
Level for the API and UI level changes for the new-ui
labels
Sep 17, 2024
hoangnt2
force-pushed
the
release/feat_rest-dependency-network-edit-page
branch
from
October 30, 2024 10:15
2e17069
to
6440152
Compare
hoangnt2
requested review from
heliocastro,
GMishx,
KoukiHama,
arunazhakesan and
ag4ums
as code owners
October 30, 2024 10:15
hoangnt2
force-pushed
the
release/feat_rest-dependency-network-edit-page
branch
2 times, most recently
from
November 5, 2024 02:35
6396d48
to
917103b
Compare
hoangnt2
force-pushed
the
release/feat_rest-dependency-network-edit-page
branch
from
November 8, 2024 03:55
917103b
to
5a9b73b
Compare
GMishx
requested changes
Nov 8, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor documentation changes needed.
...ce-server/src/main/java/org/eclipse/sw360/rest/resourceserver/release/ReleaseController.java
Outdated
Show resolved
Hide resolved
...ce-server/src/main/java/org/eclipse/sw360/rest/resourceserver/release/ReleaseController.java
Outdated
Show resolved
Hide resolved
...ce-server/src/main/java/org/eclipse/sw360/rest/resourceserver/release/ReleaseController.java
Show resolved
Hide resolved
…in dependency network of a project Signed-off-by: hoangnt2 <[email protected]>
…release Signed-off-by: hoangnt2 <[email protected]>
… with default network Signed-off-by: hoangnt2 <[email protected]>
Signed-off-by: hoangnt2 <[email protected]>
hoangnt2
force-pushed
the
release/feat_rest-dependency-network-edit-page
branch
from
November 8, 2024 07:27
5a9b73b
to
eafef43
Compare
GMishx
approved these changes
Nov 8, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes looks good.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
needs general test
This is general testing, meaning that there is no org specific issue to check for
New-UI
Level for the API and UI level changes for the new-ui
REST
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Create new endpoints that allow to add/update/edit project with dependency network
I have split this PR to separate commits, that will make it easier for reviewers to review. (Will squash commits after review successfully if needed)
This PR contains 6 new endpoints:
Pre-condition:
Turn on feature by adding this property into /etc/sw360/sw360.properties: enable.flexible.project.release.relationship=true
Create a new project with dependency network:
How To Test?
1. Get linked releases in dependency network of a project**
2. Get linked releases of a release
3. Get linked releases from sub projects of a project
Step 1: Create a parent project of create Test_PR (in pre-condition):
Step 2: Get linked releases of sub projects (Test_PR) from parent project (Test_PR_Parent_Project):
4. Compare project network (relationship in project network) with default network (relationship between release in release table)
5. Check cyclic links between releases
6. Duplicate project with network: