Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(rest): Added a commit message while create a moderation request. #2405

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(rest): Added a commit message while create a moderation request. #2405

wants to merge 1 commit into from

Conversation

nikkuma7
Copy link
Contributor

Please provide a summary of your changes here.

  • Which issue is this pull request belonging to and how is it solving it? (Refer to issue here)
  • Did you add or update any new dependencies that are required for your change?

Issue: Closes : #2404

Suggest Reviewer

You can suggest reviewers here with an @mention.

How To Test?

How should these changes be tested by the reviewer?
Have you implemented any additional tests?

Checklist

Must:

  • All related issues are referenced in commit messages and in PR

@ag4ums ag4ums added the WIP work in progress label Apr 15, 2024
@nikkuma7 nikkuma7 force-pushed the feat/commitMessageForuserModerator branch 4 times, most recently from 37f04fa to 798d2a2 Compare April 16, 2024 05:46
@nikkuma7 nikkuma7 force-pushed the feat/commitMessageForuserModerator branch 2 times, most recently from 92785fb to b7b3c51 Compare May 6, 2024 07:25
@nikkuma7 nikkuma7 force-pushed the feat/commitMessageForuserModerator branch from b7b3c51 to fcd4263 Compare May 13, 2024 10:12
@GMishx
Copy link
Member

GMishx commented Oct 21, 2024

(from discussion) The new front-end should be aware that current action will result in a Moderation Request and should capture comment from user before submitting. This is the current behavior of existing UI with Liferay.

@GMishx GMishx mentioned this pull request Oct 24, 2024
Open
@nikkuma7 nikkuma7 force-pushed the feat/commitMessageForuserModerator branch from fcd4263 to 655f85c Compare November 14, 2024 08:27
@nikkuma7 nikkuma7 force-pushed the feat/commitMessageForuserModerator branch 3 times, most recently from a24c951 to d74f7ea Compare November 25, 2024 08:36
@nikkuma7 nikkuma7 force-pushed the feat/commitMessageForuserModerator branch from d74f7ea to 029d4bd Compare November 25, 2024 09:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@heliocastro heliocastro Awaiting requested review from heliocastro heliocastro is a code owner

@GMishx GMishx Awaiting requested review from GMishx GMishx is a code owner

@KoukiHama KoukiHama Awaiting requested review from KoukiHama KoukiHama is a code owner

@arunazhakesan arunazhakesan Awaiting requested review from arunazhakesan arunazhakesan is a code owner

@ag4ums ag4ums Awaiting requested review from ag4ums ag4ums is a code owner

At least 1 approving review is required to merge this pull request.

Assignees

@nikkuma7 nikkuma7

Labels
WIP work in progress
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

feat(rest): User add a commit message while create a moderation request.
4 participants
@nikkuma7 @GMishx @heliocastro @ag4ums