Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(rest) : attachment usage type fix in response #2326

Merged
merged 1 commit into from
Mar 22, 2024
Merged

fix(rest) : attachment usage type fix in response #2326

merged 1 commit into from
Mar 22, 2024

Conversation

keerthi-bl
Copy link
Contributor

@keerthi-bl keerthi-bl commented Feb 22, 2024 •
edited
Loading

Please provide a summary of your changes here.

  • Which issue is this pull request belonging to and how is it solving it? (Refer to issue here)
  • Did you add or update any new dependencies that are required for your change?

Issue:
Closes #2318

Suggest Reviewer

You can suggest reviewers here with an @mention.

How To Test?

How should these changes be tested by the reviewer?
Have you implemented any additional tests?

Checklist

Must:

  • All related issues are referenced in commit messages and in PR

@ag4ums ag4ums added needs code review needs general test This is general testing, meaning that there is no org specific issue to check for labels Feb 22, 2024
@rudra-superrr rudra-superrr self-assigned this Feb 28, 2024
@rudra-superrr
Copy link
Contributor

Too many fields are getting returned.

image

(highlighted fields not required)

@keerthi-bl
Copy link
Contributor Author

Changes pushed @rudra-superrr

@rudra-superrr
Copy link
Contributor

oblComp_4(1) release has 3 attachments and your response is showing only 1 as you converted list of attachment to map.

image

image

@rudra-superrr rudra-superrr added needs general test This is general testing, meaning that there is no org specific issue to check for and removed needs general test This is general testing, meaning that there is no org specific issue to check for labels Mar 12, 2024
@rudra-superrr
Copy link
Contributor

duplicate attachments for some releases.

image

@rudra-superrr
Copy link
Contributor

Release Id not getting shown in release link.
image

@rudra-superrr
Copy link
Contributor

Testing was successful.

@rudra-superrr rudra-superrr removed the needs general test This is general testing, meaning that there is no org specific issue to check for label Mar 21, 2024
@rudra-superrr
Copy link
Contributor

LGTM

@rudra-superrr rudra-superrr added ready ready to merge and removed needs code review labels Mar 22, 2024
@ag4ums ag4ums merged commit c93fae9 into eclipse-sw360:main Mar 22, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@rudra-superrr rudra-superrr

Labels
ready ready to merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Return value of field attachmentType in endpoint '/projects/{id}/attachmentUsage' in incorrect format.
3 participants
@keerthi-bl @rudra-superrr @ag4ums