fix(rest): Create new endpoint for LicenseType in admin tab #2147
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nikkuma7
force-pushed
the
fix/AdminCreateLicenseType
branch
from
020f0f4
to
5541267
Compare
nikkuma7
changed the title
ag4ums
added
needs code review
needs general test
nikkuma7
force-pushed
the
fix/AdminCreateLicenseType
branch
from
5541267
to
d89c0d2
Compare
| @@ -142,3 +142,15 @@ include::{snippets}/should_document_import_osadl_info/curl-request.adoc[] | |||
|
|
|||
| ===== Example response | |||
| include::{snippets}/should_document_import_osadl_info/http-response.adoc[] | |||
|
|
|||
| [[add-license-type]] | |||
| ==== create license type | |||
There was a problem hiding this comment.
Change it to Create license type.
| ==== create license type | ||
|
|
||
| A `POST` request help to create license type. | ||
|
|
There was a problem hiding this comment.
add request parameter for your POST request
| public void should_document_import_osadl_info() throws Exception { | ||
| String accessToken = TestHelper.getAccessToken(mockMvc, testUserId, testUserPassword); | ||
| mockMvc.perform(post("/api/licenses/import/OSADL") | ||
| .header("Authorization", "Bearer " + accessToken) | ||
| .accept(MediaTypes.HAL_JSON)) | ||
| .andExpect(status().isOk()); | ||
| } | ||
|
|
||
| @Test |
There was a problem hiding this comment.
use proper indentation
|
Testing failed. |
nikkuma7
force-pushed
the
fix/AdminCreateLicenseType
branch
from
d89c0d2
to
7aacb90
Compare
|
As per your above comment, code has modified. Please retest. |
nikkuma7
force-pushed
the
fix/AdminCreateLicenseType
branch
3 times, most recently
from
d861d16
to
98993c0
Compare
|
Testing was successful. |
rudra-superrr
removed
the
needs general test
| @@ -126,19 +126,57 @@ include::{snippets}/should_document_get_download_license_archive/http-response.a | |||
|
|
|||
| A `POST` request will upload license file. | |||
|
|
|||
| [black]#Request parameter# | |||
There was a problem hiding this comment.
don't style the headings with black.
Signed-off-by: Nikesh kumar <[email protected]>
nikkuma7
force-pushed
the
fix/AdminCreateLicenseType
branch
from
98993c0
to
d261f70
Compare
|
Code looks good. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: #2146
Suggest Reviewer
How To Test?
1: Login with Admin user.
Sample URL : http://localhost:8080/resource/api/licenses/addLicenseType
Checklist
Must: