fix(rest): create new endpoint for import spdx information in admin tab #2110
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| A `IMPORT` request will import SPDX info. | ||
|
|
There was a problem hiding this comment.
Change message to --> A POST request will import SPDX info.
| @@ -35,6 +36,8 @@ | |||
| import org.springframework.web.bind.annotation.RequestBody; | |||
| import org.springframework.web.bind.annotation.RequestMapping; | |||
| import org.springframework.web.bind.annotation.RequestMethod; | |||
| import org.springframework.web.bind.annotation.RequestParam; | |||
| import org.springframework.web.multipart.MultipartFile; | |||
| import org.springframework.web.servlet.support.ServletUriComponentsBuilder; | |||
There was a problem hiding this comment.
Remove the above three imports as they are not used.
| } else { | ||
| throw new HttpMessageNotReadableException("Unable to import All Spdx license. User is not admin"); | ||
| } | ||
| } | ||
| } |
There was a problem hiding this comment.
Use proper indentation for the above method.
rudra-superrr
added
needs code review
needs general test
|
Rest doc is broken.
|
nikkuma7
force-pushed
the
fix/ImportSPDXInformation
branch
from
9445da8
to
be18503
Compare
Signed-off-by: Nikesh kumar <[email protected]>
nikkuma7
force-pushed
the
fix/ImportSPDXInformation
branch
from
be18503
to
de67119
Compare
done. |
|
code looks good. |
|
Testing was successful. |
rudra-superrr
added
ready
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: #2111
Suggest Reviewer
How To Test?
1: login sw360 with admin user
2: /resource/api/licenses/import/SPDX
Checklist
Must: