Skip to content

Commit

Permalink
chore: Remove pre-commit checkstyle in favour of maven solution
Browse files Browse the repository at this point in the history
Checkstyle used in pre-commit rule depends on docker based setup, which
is not intended to enforce to al developers in their environments.

Using maven checkstyle solution not enforced is an intermediary solution
to start improve the source quality until we get the enforce status.

Signed-off-by: Helio Chissini de Castro <[email protected]>
  • Loading branch information
heliocastro committed Nov 5, 2024
1 parent cd8b354 commit efcc1c0
Show file tree
Hide file tree
Showing 4 changed files with 454 additions and 20 deletions.
4 changes: 0 additions & 4 deletions .pre-commit-config.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -11,10 +11,6 @@ repos:
hooks:
- id: conventional-pre-commit
stages: [commit-msg]
- repo: https://github.com/gherynos/pre-commit-java
rev: v0.6.4
hooks:
- id: checkstyle
- repo: https://github.com/gitleaks/gitleaks
rev: v8.21.2
hooks:
Expand Down
16 changes: 0 additions & 16 deletions checkstyle.xml

This file was deleted.

19 changes: 19 additions & 0 deletions scripts/lint/checkstyle.xml
Original file line number Diff line number Diff line change
@@ -0,0 +1,19 @@
<?xml version="1.0"?>
<!DOCTYPE module PUBLIC "-//Checkstyle//DTD Checkstyle Configuration 1.3//EN" "https://checkstyle.org/dtds/configuration_1_3.dtd">

<module name="Checker">
<property name="charset" value="UTF-8"/>

<!-- Import Google style configuration -->
<module name="TreeWalker">
<module name="ImportControl">
<property name="file" value="scripts/lint/google_checks.xml"/>
</module>
</module>


<module name="LineLength">
<property name="max" value="120"/>
<property name="ignorePattern" value="^$"/>
</module>
</module>
Loading

0 comments on commit efcc1c0

Please sign in to comment.