Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: add requirements for Bazel #9

Merged
merged 1 commit into from
Nov 28, 2024
Merged

docs: add requirements for Bazel #9

merged 1 commit into from
Nov 28, 2024

Conversation

ltekieli
Copy link
Member

@ltekieli ltekieli commented Nov 27, 2024 •
edited
Loading

Improvement

Description

This PR adds stakeholder and tool requirements for Bazel usage across the Score project.

Related ticket

Issue-ref: see #7

@ltekieli ltekieli force-pushed the lt_bazel_build_test_int branch from f010081 to 4359911 Compare November 27, 2024 13:07
@ltekieli ltekieli requested a review from masc2023 November 27, 2024 13:07
@github-actions GitHub Actions
Copy link

Documentation artifact: https://github.com/eclipse-score/score/actions/runs/12050935687/artifacts/2244465895

@ltekieli ltekieli linked an issue Nov 27, 2024 that may be closed by this pull request
Improvement: Bazel as build, test and integration tool #7
Closed
@ltekieli ltekieli removed a link to an issue Nov 27, 2024
Improvement: Bazel as build, test and integration tool #7
Closed
masc2023
masc2023 approved these changes Nov 27, 2024
View reviewed changes
Copy link

@masc2023 masc2023 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ltekieli ltekieli force-pushed the lt_bazel_build_test_int branch from 4359911 to 08f7584 Compare November 27, 2024 13:26
@ltekieli ltekieli requested a review from masc2023 November 27, 2024 13:27
@github-actions GitHub Actions
Copy link

Documentation artifact: https://github.com/eclipse-score/score/actions/runs/12051274694/artifacts/2244564434

masc2023
masc2023 approved these changes Nov 27, 2024
View reviewed changes
Copy link

@masc2023 masc2023 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, recommendation would be to put the content of the issue in the description of the PR and link also the Issue to the PR, still mentioned Caution, PR: TBD

@ltekieli ltekieli mentioned this pull request Nov 27, 2024
Closed
@ltekieli ltekieli force-pushed the lt_bazel_build_test_int branch from 08f7584 to 02edbde Compare November 27, 2024 14:46
@github-actions GitHub Actions
Copy link

Documentation artifact: https://github.com/eclipse-score/score/actions/runs/12052697647/artifacts/2244996863

masc2023
masc2023 approved these changes Nov 27, 2024
View reviewed changes
Copy link

@masc2023 masc2023 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fine for me to have the technical solution placed under docs/features

@ltekieli ltekieli force-pushed the lt_bazel_build_test_int branch from 02edbde to a3dbe89 Compare November 28, 2024 07:13
@ltekieli ltekieli requested a review from masc2023 November 28, 2024 07:13
@ltekieli ltekieli force-pushed the lt_bazel_build_test_int branch from a3dbe89 to 9ad6af6 Compare November 28, 2024 07:14
@github-actions GitHub Actions
Copy link

Documentation artifact: https://github.com/eclipse-score/score/actions/runs/12064178716/artifacts/2248293786

@github-actions GitHub Actions
Copy link

Documentation artifact: https://github.com/eclipse-score/score/actions/runs/12064190305/artifacts/2248296267

@ltekieli ltekieli force-pushed the lt_bazel_build_test_int branch from 9ad6af6 to 2881074 Compare November 28, 2024 08:05
@ltekieli ltekieli requested review from masc2023 and hoe-jo November 28, 2024 08:05
@github-actions GitHub Actions
Copy link

Documentation artifact: https://github.com/eclipse-score/score/actions/runs/12064818122/artifacts/2248446017

masc2023
masc2023 approved these changes Nov 28, 2024
View reviewed changes
Copy link

@masc2023 masc2023 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Content wise fine for me, concerning some format aspects, we may improve, but as long we as no agreed guidance, it does not matter for now

@ltekieli ltekieli force-pushed the lt_bazel_build_test_int branch from 2881074 to be83162 Compare November 28, 2024 09:15
@github-actions GitHub Actions
Copy link

Documentation artifact: https://github.com/eclipse-score/score/actions/runs/12065873223/artifacts/2248723958

@ltekieli ltekieli marked this pull request as ready for review November 28, 2024 13:01
masc2023
masc2023 approved these changes Nov 28, 2024
View reviewed changes
Copy link

@masc2023 masc2023 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ltekieli ltekieli merged commit c6a1d14 into main Nov 28, 2024
8 checks passed
@ltekieli ltekieli deleted the lt_bazel_build_test_int branch November 28, 2024 15:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@masc2023 masc2023 masc2023 approved these changes

@antonkri antonkri antonkri approved these changes

@hoe-jo hoe-jo Awaiting requested review from hoe-jo

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ltekieli @antonkri @masc2023