Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: add esbonio for preview/linting of sphinx documentation #88

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

AlexanderLanin
Copy link

@AlexanderLanin AlexanderLanin commented Dec 13, 2024

Part 1 of #30:
Introduce initial highlighting, preview and linting for .rst and .md files (-> esbonio)

New dependency aspect_rules_py is Apache-2.0 Licensed

@AlexanderLanin AlexanderLanin marked this pull request as ready for review December 16, 2024 07:37
@MaximilianSoerenPollak
Copy link

Looks good to me.
These are changes we had in the other repository and there they worked as expected. 👍

README.md Outdated Show resolved Hide resolved
@AlexanderLanin
Copy link
Author

CI is not considered here. I'd rather implement that in combination with PR-based previews of the documentation in a separate PR.

@AlexanderLanin
Copy link
Author

AlexanderLanin commented Dec 17, 2024

Issue-ref
Bug in gitlint: The check does not match contribution guidelines. Body does not have to reference an issue anymore.
--> #117

title-match-regex
My goal was to squash the commits here in the Web UI and adapt the commit heading at that point. However I cannot do that, since merge is blocked. So I basically have to adapt my commits... which will not end up in the history anyway!
And note: once I do that, I might loose the prefix, even if all commits had one ⚠️

@AlexanderLanin
Copy link
Author

AlexanderLanin commented Dec 17, 2024

Squashed + rebased + commit msg adjusted.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants