Improve line length settings #76
Conversation
|
This makes sense I would say. |
|
Could someone merge this? I don't have write access to score. |
|
@AlexanderLanin please just fix gitlint and we are ready to go. |
Currently "mandatory wrapping" is configured in the project settings, which is not what everyone wants. Example: It took me a surprisingly long amount of time to understand a line of code, because it looked like two lines. I've not used wrapping in the last 10 years... or ever. At the same time let's add a python ruler for 80 characters, since it's the de-facto-standard. Not only de-factory, it is the standard. See PEP-8. Signed-off-by: Alexander Lanin <[email protected]> Issue-Ref: see eclipse-score#76
AlexanderLanin
force-pushed
the
line-length
branch
from
97c1642 to
83f30e1
Compare
|
Rebased + changed commit message |
|
gitlint check failed @ltekieli how do we handle these type of issues. message has to be changed? |
Yes, the git guideline has all the necessary information for properly formatting a commit message: This is enforced by gitlint which is run in a github action. |
the title pre-fix so IDE in this case has to be lowercase. uppercase is not allowed. Allowed regex:
Have to change the Regex: The rest seems to be okay as far as I can tell. Edit: removed mistake. |
|
My fault, I'll fix it. We would benefit from better error messages, but I'm not sure this is possible with git-lint. |
Currently "mandatory wrapping" is configured in the project settings, which is not what everyone wants. Example: It took me a surprisingly long amount of time to understand a line of code, because it looked like two lines. I've not used wrapping in the last 10 years... or ever. At the same time let's add a python ruler for 80 characters, since it's the de-facto-standard. Not only de-factory, it is the standard. See PEP-8. Signed-off-by: Alexander Lanin <[email protected]> Issue-ref: see eclipse-score#76
AlexanderLanin
force-pushed
the
line-length
branch
from
83f30e1 to
6f6cd08
Compare
|
Rebased + fixed commit message (I'm referencing this PR as there is no issue and #119 is not decided) |
Currently "mandatory wrapping" is configured in the project settings, which is not what everyone wants.
Example: It took me a surprisingly long amount of time to understand a line of code, because it looked like two lines. I've not used wrapping in the last 10 years... or ever.
At the same time let's add a python ruler for 80 characters, since it's the de-facto-standard. Not only de-facto, it is the standard. See PEP-8.