Lift requirement for Issue-Ref in commit message #137
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Commits are linked by Github to the PR that introduced them. It is impossible to merge a commit without PR. Hence, it is sufficient if the PR links to issues. We have no tooling that would verify that the linkage of a commit is correct. Thus, making an issue reference in the commit message mandatory holds no benefit. It is still allowed to reference an issue in a commit message. It is simply no longer mandatory. Issue-ref: closes #131 Issue-ref: closes #119
LittleHuba
force-pushed
the
ulhu_no_issue_ref
branch
from
b447c78 to
1f8bd50
Compare
|
Documentation artifact: https://github.com/eclipse-score/score/actions/runs/12432214199/artifacts/2348488400 |
|
Documentation artifact: https://github.com/eclipse-score/score/actions/runs/12432226776/artifacts/2348491565 |
|
This PR doesn't closes #131. Please read all points of acceptance criteria. This PR just solves one point but it doesn't cover whole scope. Adjust PR description to reflect this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commits are linked by Github to the PR that introduced them. It is impossible to merge a commit without PR.
Hence, it is sufficient if the PR links to issues.
We have no tooling that would verify that the linkage of a commit is correct. Thus, making an issue reference in the commit message mandatory holds no benefit.
It is still allowed to reference an issue in a commit message. It is simply no longer mandatory.
Issue-ref: closes #131
Issue-ref: closes #119