GH-5208 Enable request tracing through logs using new associated request id #5209
Conversation
| private volatile String origThreadName; | ||
|
|
||
| @Override | ||
| public boolean preHandle(HttpServletRequest request, HttpServletResponse response, Object handler) | ||
| throws Exception { | ||
| origThreadName = Thread.currentThread().getName(); | ||
| Thread.currentThread().setName(getThreadName()); | ||
| MDC.put(REQUEST_ID, UUID.randomUUID().toString()); |
There was a problem hiding this comment.
I've also used MDC for this in other dev projects. It's probably still the best option.
From experience it can get quite expensive to generate a lot of UUIDs especially if the transactions are very small. Can we have the UUID as a string at startup and then an AtomicLong that we increment and append?
There was a problem hiding this comment.
Good point! Should be changed. Introduced a process UUID which is postpended with an AtomicLong in a format which should be parsable by some tooling if need be.
Let me know your thoughts.
| @@ -24,13 +28,23 @@ | |||
| */ | |||
| public abstract class ServerInterceptor implements HandlerInterceptor { | |||
|
|
|||
| private static final String REQUEST_ID_KEY = "requestId"; | |||
There was a problem hiding this comment.
I'm having some second doubts about the naming. We have users that extend the RDF4J server code and it could be that they are already doing something similar to this. Do you think we could call ours rdf4jRequestId just to be sure that we don't overwrite someone else's request ID?
There was a problem hiding this comment.
Ahh fair point. I've also seen the package name convention used. Something like org.eclipse.rdf4j.requestId so there would never be the possibility of a clash unless we did it to ourselves?
There was a problem hiding this comment.
Package name looks very nice!
…sociated request id
benherber
force-pushed
the
GH-5208-track-requests-in-logs
branch
from
bb63f00 to
222760e
Compare
GitHub issue resolved: #5208
Briefly describe the changes proposed in this PR:
This PR adds a unique request identifier to MDC in order to allow for more intelligent log parsing and aggregation as well as aid in server debugging.
PR Author Checklist (see the contributor guidelines for more details):
mvn process-resourcesto format from the command line)