Skip to content

Commit

Permalink
GH-4324 Separate out the formatting check into its own action
Browse files Browse the repository at this point in the history
Signed-off-by: Jerven Bolleman <[email protected]>
  • Loading branch information
JervenBolleman committed Dec 16, 2022
1 parent 2d558da commit 4d8cb1b
Showing 1 changed file with 27 additions and 6 deletions.
33 changes: 27 additions & 6 deletions .github/workflows/pr-verify.yml
Original file line number Diff line number Diff line change
Expand Up @@ -3,11 +3,11 @@ name: PR verify
on: pull_request

jobs:
build:
formatting:
runs-on: ubuntu-latest
strategy:
matrix:
jdk: [11, 18]
jdk: 18
steps:
- uses: actions/checkout@v2
- name: Set up JDK
Expand All @@ -23,6 +23,31 @@ jobs:
${{ runner.os }}-jdk${{ matrix.jdk }}-maven-
- name: Check formatting
run: mvn -B formatter:validate impsort:check xml-format:xml-check
- name: Cancel workflow on failure
uses: vishnudxb/[email protected]
if: failure()
with:
repo: eclipse/rdf4j
workflow_id: ${{ github.run_id }}
access_token: ${{ github.token }}
build:
runs-on: ubuntu-latest
strategy:
matrix:
jdk: [11, 18]
steps:
- uses: actions/checkout@v2
- name: Set up JDK
uses: actions/setup-java@v1
with:
java-version: ${{ matrix.jdk }}
- name: Cache local Maven repository
uses: actions/cache@v2
with:
path: ~/.m2/repository
key: ${{ runner.os }}-jdk${{ matrix.jdk }}-maven-${{ hashFiles('**/pom.xml') }}
restore-keys: |
${{ runner.os }}-jdk${{ matrix.jdk }}-maven-
- name: Build
run: mvn -B -U -T 2 clean install -Pquick,-formatting -Dmaven.javadoc.skip=true -Djapicmp.skip -Denforcer.skip=true -Danimal.sniffer.skip=true
- name: Test
Expand Down Expand Up @@ -54,8 +79,6 @@ jobs:
key: ${{ runner.os }}-jdk11-maven-${{ hashFiles('**/pom.xml') }}
restore-keys: |
${{ runner.os }}-jdk11-maven-
- name: Check formatting
run: mvn -B formatter:validate impsort:check xml-format:xml-check
- name: Build
run: mvn -B -U -T 2 clean install -Pquick,-formatting -Dmaven.javadoc.skip=true -Djapicmp.skip -Denforcer.skip=true -Danimal.sniffer.skip=true
- name: Verify
Expand Down Expand Up @@ -87,8 +110,6 @@ jobs:
key: ${{ runner.os }}-jdk11-maven-${{ hashFiles('**/pom.xml') }}
restore-keys: |
${{ runner.os }}-jdk11-maven-
- name: Check formatting
run: mvn -B formatter:validate impsort:check xml-format:xml-check
- name: Build
run: mvn -B -U -T 2 clean install -Pquick,-formatting -Dmaven.javadoc.skip=true -Djapicmp.skip -Denforcer.skip=true -Danimal.sniffer.skip=true
- name: Verify
Expand Down

0 comments on commit 4d8cb1b

Please sign in to comment.