Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change fields to methods to support overriding #1664

Merged
merged 2 commits into from
Sep 6, 2024
Merged

Change fields to methods to support overriding #1664

merged 2 commits into from
Sep 6, 2024

Conversation

aabounegm
Copy link
Member

indentMatcher and dedentMatcher were defined as normal fields whose values were functions, which prevented calling them using super in an override. This converts them to normal methods to support overriding them.

msujew
msujew approved these changes Sep 5, 2024
View reviewed changes
Copy link
Member

@msujew msujew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

This was referenced Sep 6, 2024
Merged
Merged
@msujew msujew merged commit 707d2f7 into eclipse-langium:main Sep 6, 2024
4 checks passed
@aabounegm aabounegm deleted the fix/indentation-matching-override branch September 6, 2024 10:13
@msujew msujew added this to the v3.2.0 milestone Sep 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@msujew msujew msujew approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v3.2.0
Development

Successfully merging this pull request may close these issues.
2 participants
@aabounegm @msujew