Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Dockerfile #312

Merged
merged 1 commit into from
Dec 3, 2024
Merged

Update Dockerfile #312

merged 1 commit into from
Dec 3, 2024

Conversation

youngledo
Copy link
Contributor

Dockerfile does not expose ports, resulting in the inability to set ports when running images in Docker Desktop.

image

@youngledo
Update Dockerfile
b0149da 
fix: expose port.
@D-D-H D-D-H self-requested a review December 2, 2024 05:33
@D-D-H
Copy link
Contributor

D-D-H commented Dec 3, 2024 •
edited
Loading

We currently use port mapping at:

https://github.com/eclipse/jifa/blob/02484175645658084ab3d8e9013d3d5373de50fe/jifa.sh#L31

I have looked at some well-known projects' docker files, and exposing ports in docker files is common practice.

@D-D-H
Copy link
Contributor

D-D-H commented Dec 3, 2024

Thanks for the contribution.
Please sign the eca before I can merge it.

@youngledo
Copy link
Contributor Author

Can you solve this issue(#295) by the way?

@D-D-H D-D-H merged commit 6be0661 into eclipse-jifa:main Dec 3, 2024
2 checks passed
@D-D-H
Copy link
Contributor

D-D-H commented Dec 3, 2024

Can you solve this issue(#295) by the way?

Okay, I am running the action.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@D-D-H D-D-H D-D-H approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@youngledo @D-D-H