-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[#500] Expose UniquePortId bytes in CXX API #501
[#500] Expose UniquePortId bytes in CXX API #501
Conversation
I implemented the API for EDIT: I went ahead and implemented a rest to unblock myself. Let me know if you see a better way though. |
33b1d13
to
515da9d
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #501 +/- ##
==========================================
- Coverage 79.31% 79.06% -0.26%
==========================================
Files 200 201 +1
Lines 23757 24142 +385
==========================================
+ Hits 18843 19088 +245
- Misses 4914 5054 +140
|
515da9d
to
2d1b857
Compare
2d1b857
to
ebc2875
Compare
@elfenpiff @elBoberido Could you take a look at this |
e6770d0
to
9a9d4af
Compare
…queNotifierId UniqueListenerId bytes in CXX API
5ef51a5
to
846665e
Compare
846665e
to
5703e94
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just skimmed over the PR and the missing const
grabbed my attention :)
Notes for Reviewer
Provides an API to access the bytes representing a
UniquePortId
from the CXX API.Pre-Review Checklist for the PR Author
SPDX-License-Identifier: Apache-2.0 OR MIT
iox2-123-introduce-posix-ipc-example
)[#123] Add posix ipc example
)task-list-completed
)Checklist for the PR Reviewer
Post-review Checklist for the PR Author
References
Closes #500