Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#500] Expose UniquePortId bytes in CXX API #501

Merged

Conversation

orecham
Copy link
Contributor

@orecham orecham commented Nov 2, 2024

Notes for Reviewer

Provides an API to access the bytes representing a UniquePortId from the CXX API.

Pre-Review Checklist for the PR Author

  1. Add sensible notes for the reviewer
  2. PR title is short, expressive and meaningful
  3. Relevant issues are linked in the References section
  4. Every source code file has a copyright header with SPDX-License-Identifier: Apache-2.0 OR MIT
  5. Branch follows the naming format (iox2-123-introduce-posix-ipc-example)
  6. Commits messages are according to this guideline
  7. Tests follow the best practice for testing
  8. Changelog updated in the unreleased section including API breaking changes
  9. Assign PR to reviewer
  10. All checks have passed (except task-list-completed)

Checklist for the PR Reviewer

  • Commits are properly organized and messages are according to the guideline
  • Unit tests have been written for new behavior
  • Public API is documented
  • PR title describes the changes

Post-review Checklist for the PR Author

  1. All open points are addressed and tracked via issues

References

Closes #500

@orecham orecham changed the title [#500] Expose UniquePortId bytes in CXX API WIP: [#500] Expose UniquePortId bytes in CXX API Nov 2, 2024
@orecham
Copy link
Contributor Author

orecham commented Nov 2, 2024

@elBoberido @elfenpiff

I implemented the API for UniquePublisherId but want to get some feedback before implementing it for the rest. What do you guys think of this approach?

EDIT: I went ahead and implemented a rest to unblock myself. Let me know if you see a better way though.

@orecham orecham force-pushed the iox2-500-expose-unique-id-bytes-in-cxx branch from 33b1d13 to 515da9d Compare November 2, 2024 10:29
Copy link

codecov bot commented Nov 2, 2024

Codecov Report

Attention: Patch coverage is 0% with 3 lines in your changes missing coverage. Please review.

Project coverage is 79.06%. Comparing base (f2a948b) to head (55519ac).
Report is 28 commits behind head on main.

Files with missing lines Patch % Lines
iceoryx2/src/port/port_identifiers.rs 0.00% 3 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #501      +/-   ##
==========================================
- Coverage   79.31%   79.06%   -0.26%     
==========================================
  Files         200      201       +1     
  Lines       23757    24142     +385     
==========================================
+ Hits        18843    19088     +245     
- Misses       4914     5054     +140     
Files with missing lines Coverage Δ
iceoryx2/src/port/port_identifiers.rs 63.63% <0.00%> (-23.87%) ⬇️

... and 18 files with indirect coverage changes

---- 🚨 Try these New Features:

@orecham orecham force-pushed the iox2-500-expose-unique-id-bytes-in-cxx branch from 515da9d to 2d1b857 Compare November 2, 2024 12:36
@orecham orecham force-pushed the iox2-500-expose-unique-id-bytes-in-cxx branch from 2d1b857 to ebc2875 Compare November 2, 2024 12:38
@orecham orecham self-assigned this Nov 2, 2024
@orecham
Copy link
Contributor Author

orecham commented Nov 6, 2024

@elfenpiff @elBoberido Could you take a look at this

@orecham orecham changed the title WIP: [#500] Expose UniquePortId bytes in CXX API [#500] Expose UniquePortId bytes in CXX API Nov 6, 2024
@orecham orecham force-pushed the iox2-500-expose-unique-id-bytes-in-cxx branch from e6770d0 to 9a9d4af Compare November 13, 2024 14:35
@orecham orecham force-pushed the iox2-500-expose-unique-id-bytes-in-cxx branch 2 times, most recently from 5ef51a5 to 846665e Compare November 13, 2024 14:44
@orecham orecham force-pushed the iox2-500-expose-unique-id-bytes-in-cxx branch from 846665e to 5703e94 Compare November 13, 2024 14:47
Copy link
Member

@elBoberido elBoberido left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just skimmed over the PR and the missing const grabbed my attention :)

iceoryx2-ffi/cxx/include/iox2/unique_port_id.hpp Outdated Show resolved Hide resolved
@orecham orecham merged commit 2bfd0c9 into eclipse-iceoryx:main Nov 19, 2024
47 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Expose UniquePortId value in C/C++ API
3 participants