-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
iox-#73 Support cross compile for aarch64 #74
base: main
Are you sure you want to change the base?
Conversation
@cnwzhjs it seems the new code is not formatted with rustfmt. Can you run |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a a brief look at the bundled sources. I'm afraid but we cannot bundle them into this repository.
Sure, I'll do that as soon as confirming of how we handle the acl/attr dependencies |
Hi @elBoberido , I've just force updated the branch to fix the issues:
|
@cnwzhjs I'll have a closer look to it later on but could you also add a new CI job for cross compiling? Just to ensure we don't break it in the future. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #74 +/- ##
==========================================
+ Coverage 49.83% 49.87% +0.04%
==========================================
Files 20 20
Lines 1202 1207 +5
==========================================
+ Hits 599 602 +3
- Misses 603 605 +2 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Just a few nitpicks :)
Once the cross compile CI is set up this can be merged
Hi @elBoberido , I've updated the code according to your advices, thanks a lot. Talking about continuous integration, I need your advice as well: As you know, cross compiling to aarch64 requires a sysroot with all header and libraries in aarch64. In my local environment, I wrote a script to download, and extract these files from deb packages from debian or ubuntu repository to prepare this sysroot. Should we include these scripts within the repo, or do you have any other advice on this. |
Having to extract files from debian packages sounds cumbersome and might easily break. Did you check these sources?
|
Thank for th reply. The first link seems to be clean and work, I'll give it a try. |
@cnwzhjs just wanted to know if you are till working on this PR |
Pre-Review Checklist for the PR Author
rustfmt
iox-123-this-is-a-branch
)iox-#42 commit text
)task-list-completed
)Notes for Reviewer
Currently only toolchain file for target
aarch64-unknown-linux-gnu
is added. If anyone has a test platform for other targets, please add them as well.Checklist for the PR Reviewer
Post-review Checklist for the PR Author
References