Depend on com.amazonaws.aws-java-sdk-sts #86
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows using real AWS S3 with a web identity token. See [1] for details. Absence of this dependency requires using less desired password-based authentication. [1] https://github.com/aws/aws-sdk-java/blob/master/aws-java-sdk-core/src/main/java/com/amazonaws/auth/profile/internal/securitytoken/STSProfileCredentialsServiceLoader.java#L20 Signed-off-by: Zygmunt Krynicki <[email protected]>
|
Can one of the admins verify this patch? |
|
Was trying to use Web Based authentication with a custom AWS IAM Role when running hawkbit in AWS EKS Kubernetes cluster. Doing this is the best practice when it comes to providing AWS permissions for pods, but without this fix, it's not possible. I.e, I confirm this is an important patch. |
|
@stefbehl could we merge this? |
|
Still actual |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows using real AWS S3 with a web identity token. See [1] for details. Absence of this dependency requires using less desired password-based authentication.
[1] https://github.com/aws/aws-sdk-java/blob/master/aws-java-sdk-core/src/main/java/com/amazonaws/auth/profile/internal/securitytoken/STSProfileCredentialsServiceLoader.java#L20
Signed-off-by: Zygmunt Krynicki [email protected]