GLSP-1398: Properly configure default types #245
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Update graph model to add missing `GForeignObjectElement` and corresponding builder - Add empty default constructor to `GPreRenderedElementBuilder` - Update default type mapping configuration - Add missing configuration for foreign and shaped prerendered elements - Remove redundant registration of subtypes with the same eclass as the parent type - Extend deserialization test cases to ensure that all default types are properly deserialized Fixes eclipse-glsp/glsp#1398
martin-fleck-at
approved these changes
Aug 29, 2024
|
|
||
| // shapes | ||
| public static final String NODE_CIRCLE = "node:circle"; | ||
| public static final String NODE_RECTANGLE = "node:rectangle"; | ||
| public static final String NODE_DIAMOND = "node:diamond"; | ||
| public static final String FOREIGN_OBJECT = "foreign-object"; |
There was a problem hiding this comment.
nit: If we are already touching this file, I'd love to align the structuring with https://github.com/eclipse-glsp/glsp-client/blob/master/packages/protocol/src/model/default-types.ts
| assertType(nodeChidlren.get(1), GCompartment.class, DefaultTypes.COMPARTMENT); | ||
| assertType(nodeChidlren.get(2), GLabel.class, DefaultTypes.LABEL); | ||
| assertType(nodeChidlren.get(3), GPort.class, DefaultTypes.PORT); | ||
|
|
There was a problem hiding this comment.
nit: unnecessary empty line.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it does
GForeignObjectElementand corresponding builderGPreRenderedElementBuilderFixes eclipse-glsp/glsp#1398
How to test
Follow-ups
Changelog