GLSP-1380: Remove dependency to Guava #244
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removes the dependency to Google Guava. We mostly used collection creation which can be done with native Java now almost as conveniently. Other than that we only used the BiMap for source model indexing in EMF. While Guavas BIMaps are powerful most of their functionality is not required for our usecases therefore the useage got replaced with a custom BiIndex implementation. - Replaces usage of Lists.newArrayList etc. with Java native calls - Guava Preconditions were only used in two places -> replaced with in method exception handling - Introduce a `BIIndex` helper class that serves as a replacement for Guavas BIMap in source model indexing - Add test cases for the new BiIndex - Update target platforms Fixes eclipse-glsp/glsp#1380 Contributed on behalf of AxonIvy AG
martin-fleck-at
approved these changes
Aug 29, 2024
examples/org.eclipse.glsp.example.workflow/dependency-reduced-pom.xml
Outdated
Show resolved
Hide resolved
plugins/org.eclipse.glsp.layout/src/org/eclipse/glsp/layout/ElkLayoutEngine.java
Outdated
Show resolved
Hide resolved
tests/org.eclipse.glsp.server.test/src/org/eclipse/glsp/server/utils/BiIndexTest.java
Show resolved
Hide resolved
|
This should probably mentioned in the changelog or do you think it won't be necessary? |
Yes, you are right. I forgot to tick the checkboxes. Should definitely be added to the changelog |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it does
Removes the dependency to Google Guava. We mostly used collection creation which can be done with native Java now almost as conveniently. Other than that we only used the BiMap for source model indexing in EMF. While Guavas BIMaps are powerful most of their functionality is not required for our usecases therefore the useage got replaced with a custom BiIndex implementation.
BiIndexhelper class that serves as a replacement for Guavas BiMap in source model indexingFixes eclipse-glsp/glsp#1380
Contributed on behalf of AxonIvy AG
How to test
Follow-ups
Changelog