docs: improve readability of documentation #165
Conversation
MichaelSteinert
requested review from
paullatzelsperger and
ronjaquensel
as code owners
There was a problem hiding this comment.
Please create an issue as described in the contributing guide
| ./gradlew util:http-request-logger:build | ||
| HTTP_SERVER_PORT=4000 java -jar util/http-request-logger/build/libs/http-request-logger.jar | ||
| docker build -t http-request-logger util/http-request-logger | ||
| docker run -p 4000:4000 http-request-logger |
There was a problem hiding this comment.
Not sure why running it with docker should be better than running the jar directly
There was a problem hiding this comment.
First, I could not run this JAR after building it. Unfortunately, I could not fix this error:
Error: Could not find or load main class org.eclipse.edc.samples.util.HttpRequestLoggerServer
Caused by: java.lang.ClassNotFoundException: org.eclipse.edc.samples.util.HttpRequestLoggerServer
Secondly, there is a Dockerfile that is already used in other samples
There was a problem hiding this comment.
looks like the jar task in the build.gradle.kts misses to include .class files in the jar:
from(sourceSets["main"].output)with this addition to the jar task, it will work
There was a problem hiding this comment.
Thanks for your help! Now running the JAR works. I have changed the use of container back to JAR.
|
Corresponding Issue #167 |
|
This pull request is stale because it has been open for 7 days with no activity. |
|
@MichaelSteinert could you take care of make the e2e tests pass? so we can merge then |
|
@ndr-brt yes. i have fixed the e2e tests |
What this PR changes/adds
This PR:
improves the readablity of documentation
fixes some typos
uses the logging webserver as docker container instead of JAR
makes use of docker container name instead of container id in streaming sample 2
removes non-working property
maxDurationin streaming sample 2makes use of docker compose instead fo docker-compose in advanced sample 1
adds missing catalog fetch in advanced sample 1
Closes #172
Closes #167