Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add streaming http-to-http sample #102

Merged

Conversation

ndr-brt
Copy link
Member

@ndr-brt ndr-brt commented Aug 31, 2023

What this PR changes/adds

Create a simple streaming sample.

\cc @yurimssilva

Why it does that

documenting streaming capabilities

Further notes

  • created a util/http-request-logger module that will provide an http logger that can be used by different samples, for the moment it is used only by streaming-01, but it could be used by transfer-06 and transfer-07 as well (issue will come) by streaming-01, transfer-06 and transfer-07
  • deleted ISSUE_TEMPLATE and PULL_REQUEST_TEMPLATE to inherit the ones from the .github repository.

Linked Issue(s)

Closes #101

@ndr-brt ndr-brt added the enhancement New feature or request label Aug 31, 2023
Copy link

@jimmarino jimmarino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice sample, just some minor grammatical suggestions.

transfer/streaming/streaming-01-http-to-http/README.md Outdated Show resolved Hide resolved
transfer/streaming/streaming-01-http-to-http/README.md Outdated Show resolved Hide resolved
transfer/streaming/streaming-01-http-to-http/README.md Outdated Show resolved Hide resolved
transfer/streaming/streaming-01-http-to-http/README.md Outdated Show resolved Hide resolved
transfer/streaming/streaming-01-http-to-http/README.md Outdated Show resolved Hide resolved
transfer/streaming/streaming-01-http-to-http/README.md Outdated Show resolved Hide resolved
transfer/streaming/streaming-01-http-to-http/README.md Outdated Show resolved Hide resolved
transfer/streaming/streaming-01-http-to-http/README.md Outdated Show resolved Hide resolved
transfer/streaming/streaming-01-http-to-http/README.md Outdated Show resolved Hide resolved
transfer/streaming/streaming-01-http-to-http/README.md Outdated Show resolved Hide resolved
@juliapampus juliapampus merged commit be8fcd6 into eclipse-edc:main Sep 5, 2023
@ndr-brt ndr-brt deleted the 101-streaming-http-to-http branch September 5, 2023 06:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

provide Streaming HTTP-TO-HTTP streaming sample
3 participants