feat: remove MvdScopeTransformer #384
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this should be covered by the E2E tests we have in MVD |
|
the entire |
thomasrutger
changed the title
Done. I also updated the readme by moving 8.5 to 10.4 to indicate that the default |
paullatzelsperger
approved these changes
Nov 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR changes/adds
Remove
MvdScopeTransformerthat contained strange fallback behavior (from "dark times past") when an unrecognized scope credential type is encountered and use the defaultEdcScopeToCriterionTransformerinstead.Why it does that
This may be an artifact of dark times past, and could probably be removed
Further notes
@paullatzelsperger I did not add any tests, considering none of the mvd contains any tests, but I can add some if desired.
Linked Issue(s)
Closes #383