Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MvdScopeTransformer question #383

Closed
paullatzelsperger opened this issue Nov 6, 2024 Discussed in #382 · 0 comments · Fixed by #384
Closed

MvdScopeTransformer question #383

paullatzelsperger opened this issue Nov 6, 2024 Discussed in #382 · 0 comments · Fixed by #384
Labels
enhancement New feature or request

Comments

@paullatzelsperger
Copy link
Member

Discussed in #382

Originally posted by thomasrutger November 5, 2024
I noticed that the MvdScopeTransformer is very similar to the default EdcScopeToCriterionTransformer, with the exception of the list of knownCredentialTypes. In particular, if a scope string is not recognized as a "known credential" it returns the Criterion

"verifiableCredential.credential.credentialSubject.claims.level"=credentialType

The purpose of this fallback behavior is unclear to me. Does this relate to an MVD-specific scope alias, or is there another reason behind it? Why not return a failure if the scope is unrecognized?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant