feat: implement StsAccountProvisioner #458
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
...oner/src/main/java/org/eclipse/edc/identityhub/common/provisioner/StsAccountProvisioner.java
Fixed
Show fixed
Hide fixed
...oner/src/main/java/org/eclipse/edc/identityhub/common/provisioner/StsAccountProvisioner.java
Fixed
Show fixed
Hide fixed
...oner/src/main/java/org/eclipse/edc/identityhub/common/provisioner/StsAccountProvisioner.java
Fixed
Show fixed
Hide fixed
...oner/src/main/java/org/eclipse/edc/identityhub/common/provisioner/StsAccountProvisioner.java
Fixed
Show fixed
Hide fixed
|
added in 4a7e741 |
| * @param parameters Optional generator arguments, such as a salt value | ||
| * @return a randomly generated client secret. | ||
| */ | ||
| String generateClientSecret(@Nullable Object parameters); |
Check notice
Code scanning / CodeQL
Useless parameter Note
paullatzelsperger
force-pushed
the
feat/456_implement_sts_account_provisioner
branch
from
2601d03 to
7b1d9ec
Compare
paullatzelsperger
force-pushed
the
feat/456_implement_sts_account_provisioner
branch
from
56f0b37 to
1808d46
Compare
paullatzelsperger
force-pushed
the
feat/456_implement_sts_account_provisioner
branch
from
1808d46 to
a1c28cf
Compare
jimmarino
reviewed
Sep 17, 2024
core/identity-hub-did/src/main/java/org/eclipse/edc/identityhub/did/DidDocumentServiceImpl.java
Outdated
Show resolved
Hide resolved
core/identity-hub-did/src/main/java/org/eclipse/edc/identityhub/did/DidDocumentServiceImpl.java
Outdated
Show resolved
Hide resolved
...main/java/org/eclipse/edc/identityhub/common/provisioner/StsAccountProvisionerExtension.java
Outdated
Show resolved
Hide resolved
wolf4ood
approved these changes
Sep 17, 2024
paullatzelsperger
deleted the
feat/456_implement_sts_account_provisioner
branch
paullatzelsperger
added a commit
to paullatzelsperger/IdentityHub
that referenced
this pull request
Sep 17, 2024
* feat: implement StsClientProvisioner * handle deleted event * DEPENDENCIES * added StsClientSecretGenerator * add embedded STS and STS API to IH runtime * AccountProvisioner is called explicitly by ParticipantContextService * implement key-revoked and key-rotated callbacks * add new keypair descriptor to revoke/rotate event * make provisioner transactional * pr remarks * updated wording
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR changes/adds
Implements the
StsAccountProvisionerwhich creates, updates and deletesStsCliententries as a result of certain IdentityHub management actions.Here's how it works:
ParticipantContextis createdrevokedandrotatedevents are synchronized to the STS clientWhy it does that
convenience and comfort
Further notes
KeyPairAddedandKeyPairRevokednow carry theKeyPairResourceinstead of just the IDKeyPairAddedandKeyPairRevokednow carry the (nullable) description of the new keyLinked Issue(s)
Closes #456
Please be sure to take a look at the contributing guidelines and our etiquette for pull requests.