feat: activate ParticipantContext explicitly during creation #457
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jimmarino
approved these changes
Sep 12, 2024
paullatzelsperger
force-pushed
the
feat/455_activate_participantcontext_explicitly
branch
from
e191221 to
012e9d0
Compare
paullatzelsperger
force-pushed
the
feat/455_activate_participantcontext_explicitly
branch
from
012e9d0 to
ecec8b7
Compare
paullatzelsperger
deleted the
feat/455_activate_participantcontext_explicitly
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR changes/adds
This PR changes the
ParticipantContextEventCoordinatorsuch thatParticipantContextobjects are always created in theinactivestate.Then, keys are generated/added and possibly activated, and only then is the
ParticipantContextactivated, causing the DID document to be published.Why it does that
avoid multiple publications
Further notes
List other areas of code that have changed but are not necessarily linked to the main feature. This could be method
signature changes, package declarations, bugs that were encountered and were fixed inline, etc.
Linked Issue(s)
Closes #455
Please be sure to take a look at the contributing guidelines and our etiquette for pull requests.