Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: make scope parameter of PresentationQuery optional #388

Conversation

paullatzelsperger
Copy link
Member

What this PR changes/adds

makes the scope parameter of a PresentationQueryMessage optional, and adapts the CredentialQueryResolver accordingly.

  • if request scopes are provided, they must match the access token scopes.
  • if no request scopes are provided, all credentials that are selected by the access token scopes are returned

several shortcuts have been implemented, to save some database communication.

Why it does that

DCP specifies the scope parameter as optional

Further notes

List other areas of code that have changed but are not necessarily linked to the main feature. This could be method
signature changes, package declarations, bugs that were encountered and were fixed inline, etc.

Linked Issue(s)

Contributes eclipse-edc/Connector#4322

Please be sure to take a look at the contributing guidelines and our etiquette for pull requests.

@paullatzelsperger paullatzelsperger added bug Something isn't working dcp labels Jul 3, 2024
@paullatzelsperger paullatzelsperger merged commit 90e56c8 into eclipse-edc:main Jul 3, 2024
16 checks passed
@paullatzelsperger paullatzelsperger deleted the fix/make_scope_parameter_nullable branch July 3, 2024 13:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working dcp
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants