Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: allow usage of multiple local Public Keys #362

Conversation

paullatzelsperger
Copy link
Member

@paullatzelsperger paullatzelsperger commented Jun 3, 2024

What this PR changes/adds

This PR adds the KeyPairResourcePublicKeyResolver, that can resolve the IH's "own" public keys from its internal database (KeyPairResourceStore).

this allows the AccessTokenVerifier to resolve the public key from the KeyPairResourceStore rather than from a hard-coded path on the filesystem or the vault.

Why it does that

if IH supports multiple tenants, then that selection must be possible. Otherwise it remains effectively single-tenant.

Further notes

  • due to an upstream change, this also removes the ManagementApiConfiguration object and replaces it with a hard coded constant.
  • this will fix the failing build
  • renaming management-api -> identity-api will come in a subsequent PR

Linked Issue(s)

Closes #356

Please be sure to take a look at the contributing guidelines and our etiquette for pull requests.

@paullatzelsperger paullatzelsperger added the enhancement New feature or request label Jun 3, 2024
@paullatzelsperger paullatzelsperger force-pushed the feat/356_use_multiple_publickeys branch from c7c4766 to d482e80 Compare June 3, 2024 13:17
@paullatzelsperger
Copy link
Member Author

FYI @thomasrutger

@paullatzelsperger paullatzelsperger force-pushed the feat/356_use_multiple_publickeys branch from 46cd536 to c02f945 Compare June 4, 2024 08:14
@paullatzelsperger paullatzelsperger force-pushed the feat/356_use_multiple_publickeys branch from b9eb77b to ff319ab Compare June 4, 2024 08:39
@paullatzelsperger paullatzelsperger force-pushed the feat/356_use_multiple_publickeys branch from 8b81b40 to a5adb16 Compare June 4, 2024 14:01
@paullatzelsperger paullatzelsperger self-assigned this Jun 4, 2024
@paullatzelsperger paullatzelsperger marked this pull request as ready for review June 4, 2024 14:01
@paullatzelsperger paullatzelsperger merged commit ffa302c into eclipse-edc:main Jun 5, 2024
13 checks passed
@paullatzelsperger paullatzelsperger deleted the feat/356_use_multiple_publickeys branch June 5, 2024 04:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

IdentityHub should be able to use multiple local public keys
3 participants