-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: allow usage of multiple local Public Keys #362
Merged
paullatzelsperger
merged 9 commits into
eclipse-edc:main
from
paullatzelsperger:feat/356_use_multiple_publickeys
Jun 5, 2024
Merged
feat: allow usage of multiple local Public Keys #362
paullatzelsperger
merged 9 commits into
eclipse-edc:main
from
paullatzelsperger:feat/356_use_multiple_publickeys
Jun 5, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
...rc/main/java/org/eclipse/edc/identityhub/publisher/did/local/LocalDidPublisherExtension.java
Fixed
Show fixed
Hide fixed
c7c4766
to
d482e80
Compare
FYI @thomasrutger |
46cd536
to
c02f945
Compare
b9eb77b
to
ff319ab
Compare
8b81b40
to
a5adb16
Compare
jimmarino
approved these changes
Jun 4, 2024
wolf4ood
approved these changes
Jun 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR changes/adds
This PR adds the
KeyPairResourcePublicKeyResolver
, that can resolve the IH's "own" public keys from its internal database (KeyPairResourceStore
).this allows the
AccessTokenVerifier
to resolve the public key from theKeyPairResourceStore
rather than from a hard-coded path on the filesystem or the vault.Why it does that
if IH supports multiple tenants, then that selection must be possible. Otherwise it remains effectively single-tenant.
Further notes
ManagementApiConfiguration
object and replaces it with a hard coded constant.management-api
->identity-api
will come in a subsequent PRLinked Issue(s)
Closes #356
Please be sure to take a look at the contributing guidelines and our etiquette for pull requests.