Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add Credential Watchdog extension #346

Conversation

paullatzelsperger
Copy link
Member

@paullatzelsperger paullatzelsperger commented May 13, 2024

What this PR changes/adds

Adds a periodic task to check all credentials whether they are expired, not yet valid, revoked or suspended.

This does not yet check the issuance status.

Why it does that

Keep credentials and their status up-to-date

Further notes

  • REVOKED and EXPIRED are non-reversible
  • reversible status SUSPENDED and NOT_YET_VALID revert to ISSUED once they are cleared.
  • EXPIRED trumps all other states: once a credential is expired, it cannot take on another state. This is done to save remote calls to the revocation service. Thus, credentials that are both expired and suspended/revoked will appear as EXPIRED.
  • the Watchdog thread currently only considers credentials that are either ISSUED, SUSPENDED or NOT_YET_VALID, all others are ignored.

Linked Issue(s)

Closes #340

Please be sure to take a look at the contributing guidelines and our etiquette for pull requests.

@paullatzelsperger paullatzelsperger added the enhancement New feature or request label May 13, 2024
@paullatzelsperger paullatzelsperger marked this pull request as ready for review May 13, 2024 19:08
@paullatzelsperger paullatzelsperger force-pushed the feat/340_credential_watchdog branch from bd1fa47 to 0ee77fe Compare May 13, 2024 19:16
@paullatzelsperger paullatzelsperger force-pushed the feat/340_credential_watchdog branch from 0ee77fe to cdcdc3d Compare May 13, 2024 19:18
@paullatzelsperger paullatzelsperger changed the title feat: add Credential Watchdog thread feat: add Credential Watchdog extension May 13, 2024
@paullatzelsperger paullatzelsperger force-pushed the feat/340_credential_watchdog branch from cdcdc3d to cd2a1ac Compare May 14, 2024 07:00
@paullatzelsperger paullatzelsperger force-pushed the feat/340_credential_watchdog branch from cd2a1ac to e90eafd Compare May 14, 2024 07:04
@paullatzelsperger paullatzelsperger merged commit a188d79 into eclipse-edc:main May 14, 2024
13 checks passed
@paullatzelsperger paullatzelsperger deleted the feat/340_credential_watchdog branch May 14, 2024 07:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Introduce Credentials watchdog thread
2 participants