fix: set keypair to ACTIVE #286
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
issue warning if new key is inactive, and no other active ones add endpoint to KeyPairResourceApi added tests
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| @@ -144,6 +148,13 @@ | |||
| return this; | |||
| } | |||
|
|
|||
| public KeyPairResource build() { | |||
Check notice
Code scanning / CodeQL
Missing Override annotation Note
bscholtes1A
approved these changes
Feb 29, 2024
paullatzelsperger
force-pushed
the
fix/284_set_keypair_to_active
branch
from
fd0bdb0 to
92caf3c
Compare
bscholtes1A
approved these changes
Feb 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR changes/adds
This PR fixes the handling of the KeyPairResource's ACTIVE state
Why it does that
There was no way to move the key pair to the ACTIVE state before.
Further notes
Linked Issue(s)
Closes #284
Please be sure to take a look at the contributing guidelines and our etiquette for pull requests.