feat: add SqlCredentialStore
#197
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paullatzelsperger
requested review from
bscholtes1A,
jimmarino,
ndr-brt and
wolf4ood
wolf4ood
approved these changes
Dec 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR changes/adds
This PR adds the
SqlCredentialStorefor persistent storage of VerifiableCredentials.It also makes some modifications to the existing
InMemoryCredentialStore, that became necessary due to the open structure of VCs and nested structures.Why it does that
IATP, persistent storage of VCs
Further notes
Both the in-mem query and the SQL query required quite a bit of customization, because some datastructures have a very open schema, that our existing query infrastructure (Reflection-based
query resolution, SQL statement generators,...) simply don't account for.
Builds and Tests will fail until feat: allow unchecked SQL operators Connector#3698 is mergedLinked Issue(s)
Closes #188
Please be sure to take a look at the contributing guidelines and our etiquette for pull requests.