Fix deduplication for OSCORE. #2296
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks! I will have a look and test through some OSCORE-related things |
|
Thanks for the PR! I have now done some testing and I have not found any issues introduced by this swap of layers. So I'd say we should go ahead and do it. |
|
Do you know, if the OSCORE RFC refers somehow to the CoAP MID? That may be need to consider. |
It does, but from my recollection not in any way that should be relevant or make it incorrect to do this change. However, let me check in more detail to be fully certain |
Swap OSCORE and CongestionControl layers. Add logback configuration for unittests. Issue eclipse-californium#2294 Signed-off-by: Achim Kraus <[email protected]>
boaks
force-pushed
the
fix_oscore_deduplication
branch
from
6a4386f
to
7f3c9d5
Compare
Any news? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Swap OSCORE and CongestionControl layers.
Add logback configuration for unittests.
Issue #2294