-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add bluechi_is_online system integration test #1006
Add bluechi_is_online system integration test #1006
Conversation
tests/tests/tier0/bluechi-is-online-system/test_bluechi_is_online_system.py
Outdated
Show resolved
Hide resolved
a2b8ec3
to
f91ee9e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great!
Just a small refactoring
tests/tests/tier0/bluechi-is-online-system/test_bluechi_is_online_system.py
Outdated
Show resolved
Hide resolved
f91ee9e
to
561aa9c
Compare
tests/tests/tier0/bluechi-is-online-system/test_bluechi_is_online_system.py
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall it looks good, just small suggestion
tests/tests/tier0/bluechi-is-online-system/test_bluechi_is_online_system.py
Outdated
Show resolved
Hide resolved
tests/tests/tier0/bluechi-is-online-system/test_bluechi_is_online_system.py
Outdated
Show resolved
Hide resolved
tests/tests/tier0/bluechi-is-online-system/test_bluechi_is_online_system.py
Outdated
Show resolved
Hide resolved
tests/tests/tier0/bluechi-is-online-system/test_bluechi_is_online_system.py
Show resolved
Hide resolved
561aa9c
to
4cc894b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
4cc894b
to
a085ef7
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Small change request, otherwise LGTM
tests/tests/tier0/bluechi-is-online-system/test_bluechi_is_online_system.py
Outdated
Show resolved
Hide resolved
a085ef7
to
177b6ef
Compare
Signed-off-by: nsimsolo <[email protected]>
177b6ef
to
4e2f568
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Adding test for bluechi-is-online system.
'bluechi-is-online system' command is verifying on the controller machine check and/or monitor the connection of all nodes to the controller
When all the connections are online the command return will be 0, when one of the connections is offline the command return will be 1.
Fixes: #1001
signed-off-by: Nisim Simsolo [email protected]