Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add bluechi_is_online system integration test #1006

Merged
merged 1 commit into from
Dec 12, 2024

Conversation

nsimsolo
Copy link
Contributor

@nsimsolo nsimsolo commented Dec 9, 2024

Adding test for bluechi-is-online system.
'bluechi-is-online system' command is verifying on the controller machine check and/or monitor the connection of all nodes to the controller
When all the connections are online the command return will be 0, when one of the connections is offline the command return will be 1.
Fixes: #1001
signed-off-by: Nisim Simsolo [email protected]

@nsimsolo nsimsolo force-pushed the bluechi-is-online-system branch from a2b8ec3 to f91ee9e Compare December 10, 2024 09:55
Copy link
Member

@mkemel mkemel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!
Just a small refactoring

@nsimsolo nsimsolo force-pushed the bluechi-is-online-system branch from f91ee9e to 561aa9c Compare December 10, 2024 12:19
Copy link
Member

@mwperina mwperina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall it looks good, just small suggestion

@nsimsolo nsimsolo force-pushed the bluechi-is-online-system branch from 561aa9c to 4cc894b Compare December 12, 2024 08:59
@coveralls
Copy link

coveralls commented Dec 12, 2024

Coverage Status

coverage: 81.018% (+0.03%) from 80.988%
when pulling 4e2f568 on nsimsolo:bluechi-is-online-system
into 29c0a53 on eclipse-bluechi:main.

Copy link
Member

@mwperina mwperina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mwperina mwperina force-pushed the bluechi-is-online-system branch from 4cc894b to a085ef7 Compare December 12, 2024 09:59
Copy link
Member

@engelmi engelmi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small change request, otherwise LGTM

@nsimsolo nsimsolo force-pushed the bluechi-is-online-system branch from a085ef7 to 177b6ef Compare December 12, 2024 11:31
@nsimsolo nsimsolo force-pushed the bluechi-is-online-system branch from 177b6ef to 4e2f568 Compare December 12, 2024 11:33
Copy link
Member

@engelmi engelmi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mwperina mwperina merged commit e1c7465 into eclipse-bluechi:main Dec 12, 2024
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add integration tests for bluechi-is-online system without any cli options
5 participants