scripts.set_copyright_year: Add a CI check to ensure the copyright is updated #344
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
s-heppner
requested changes
Dec 1, 2024
s-heppner
approved these changes
Dec 10, 2024
|
It looks to me like there are a lot of false import statements causing errors in the |
|
No, I do not know that. Could you maybe investigate? |
|
It seems to be a bigger problem. Even when I fix the imports the unitests fail. There seems to be quite some code that needs to be changed. I will create an issue and a seperate pull request, till this is fixed we can basically ignore the ci tests for the |
Frosty2500
force-pushed
the
add_copyright_check
branch
2 times, most recently
from
d683a27 to
37f5a3e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently we do not check if every copyright is up to date.
Now the ci pipeline will fail if the copyright is not up to date in some files.
Fixes #260
Fixes #331