Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix resizing of columns #256

Merged
merged 5 commits into from
Aug 28, 2024
Merged

Fix resizing of columns #256

merged 5 commits into from
Aug 28, 2024

Conversation

seicke
Copy link
Member

@seicke seicke commented Aug 27, 2024 •
edited
Loading

Resizing of columns leads to "width hopping", see video: https://github.com/user-attachments/assets/95660445-67b4-48b6-936f-fc7f1519f65c

@seicke seicke requested a review from aaronzi August 28, 2024 06:57
@seicke
Copy link
Member Author

seicke commented Aug 28, 2024

Tested with different window sizes, with different scalings and with opened/closed menu one the left (AASList)

  • Google Chrome v128.0.6613.85
  • Firefox v129.0.2

aaronzi
aaronzi approved these changes Aug 28, 2024
View reviewed changes
Copy link
Member

@aaronzi aaronzi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for this fix. This has bugged me as well for a long time 😉 I also really like the minimal limit for each column 👍🏻

@aaronzi aaronzi merged commit 372baa2 into eclipse-basyx:main Aug 28, 2024
2 checks passed
@seicke seicke deleted the workOnResizableColumns branch August 30, 2024 05:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aaronzi aaronzi aaronzi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@seicke @aaronzi