This repository has been archived by the owner on Sep 28, 2022. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 91
Creates a local anonymous macro #579
Draft
yloiseau
wants to merge
8
commits into
master
Choose a base branch
from
feature/eval-local-macro
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Commits on Dec 10, 2020
-
Configuration menu - View commit details
-
Copy full SHA for 902ddbb - Browse repository at this point
Copy the full SHA 902ddbbView commit details
Commits on Dec 15, 2020
-
Configuration menu - View commit details
-
Copy full SHA for ae0fb1b - Browse repository at this point
Copy the full SHA ae0fb1bView commit details -
Configuration menu - View commit details
-
Copy full SHA for f61943c - Browse repository at this point
Copy the full SHA f61943cView commit details
Commits on Dec 18, 2020
-
Configuration menu - View commit details
-
Copy full SHA for 0fdb798 - Browse repository at this point
Copy the full SHA 0fdb798View commit details -
There is an issue with classloaders while running the test module from java. It works when run directly by golo. Here I switch the current thread classloader. Works fine, but there should be a better approach (thread local singleton for `Runtime.classLoader()`.
Configuration menu - View commit details
-
Copy full SHA for 5e63d63 - Browse repository at this point
Copy the full SHA 5e63d63View commit details -
Define a thread local variable to hold the current thread classloader. When running from golo, the current thread classloader will be a GoloClassLoader instance, so it is used as is. The issue is that when running from Java, the current classloader is not a golo one, so it was wrapped by `Runtime.classLoader()`. We therefore got a different one for each call. Keeping it in a thread local singleton resolve this issue.
Configuration menu - View commit details
-
Copy full SHA for f514eff - Browse repository at this point
Copy the full SHA f514effView commit details -
Configuration menu - View commit details
-
Copy full SHA for 0575fb6 - Browse repository at this point
Copy the full SHA 0575fb6View commit details -
Configuration menu - View commit details
-
Copy full SHA for aac2c10 - Browse repository at this point
Copy the full SHA aac2c10View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.