Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Plugins #4

Open
wants to merge 9 commits into
base: master
Choose a base branch
from
Open

Plugins #4

wants to merge 9 commits into from

Conversation

blubeam
Copy link

@blubeam blubeam commented Sep 4, 2023

Ported the rawdog plugins found on offog.org/git to python3, added some documentation also.

@echarlie
Copy link
Owner

Hi bluebeam,

Thanks for doing the work to port these plugins. I just want to check a few things before I merge them:

  1. Have you tested all of them? I know it seems a little trivial, but as noted very clearly in the readme: I don't use plugins, so I actually don't know, and the time for me to evaluate them would be substantial.

  2. Can you move the descriptions of the plugins to a second README file in the plugins directory? I think that would be more clear.

  3. can you run flake8 or an equivalent linter/formatter on these so that they have consistent whitespacing?

@blubeam
Copy link
Author

blubeam commented Oct 31, 2023

  1. Yes I have spent today testing them and editing the ones that had errors
  2. The README section has been moved
  3. I have started to lint them, but this is an ongoing thing as the syntax is very old due to being Python2 files

Additionally I noticed an encoding error in my browser which was due to the rawdog.py file writing the HTML meta tag with the attribute charset=ISO-8859-1, after removing this and ensuring UTF-8 encoding throughout the problem disappeared. Please let me know if you have come across this problem before, and if you would like me to move this to a different branch so that you can merge the plugins alone.

Finally there was an AttributeError when using feedparser.urls._resolveRelativeURIs as the syntax changed so this has been updated along with the setup.py so that feedparser can be used at latest release version.

Please let me know if anything has broken or there is some massive error and I'm not aware, regards

@echarlie
Copy link
Owner

echarlie commented Jan 8, 2024

I'll try to give it a quick pass through in the next couple days.

There are a lot of little quirks in the python2 to python3 conversion that frankly I mostly hacked around to keep my feed working, so I expect breakage occasionally with changes to python and the used libraries.

@echarlie echarlie self-requested a review January 8, 2024 18:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants