Merge pull request #134 from eccenca/release/v23.3.1

Release v23.3.1 into main branch
eccenca · Nov 15, 2023 · 0c7316d · 0c7316d
2 parents e879eb0 + e81eb11
commit 0c7316d
Show file tree

Hide file tree

Showing 3 changed files with 11 additions and 5 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -6,6 +6,11 @@ The format is based on [Keep a Changelog](http://keepachangelog.com/) and this p
 
 ## [Unreleased]
 
+### Fixed
+
+-   `<ContextOverlay />`
+    -   remove always white space at start of `portalClassName` to prevent runtime error in BlueprintJS
+
 ## [23.3.0] - 2023-11-09
 
 ### Added

diff --git a/package.json b/package.json
@@ -1,7 +1,7 @@
 {
     "name": "@eccenca/gui-elements",
     "description": "GUI elements based on other libraries, usable in React application, written in Typescript.",
-    "version": "23.3.0",
+    "version": "23.3.1-rc.3",
     "license": "Apache-2.0",
     "homepage": "https://github.com/eccenca/gui-elements",
     "bugs": "https://github.com/eccenca/gui-elements/issues",

diff --git a/src/components/ContextOverlay/ContextOverlay.tsx b/src/components/ContextOverlay/ContextOverlay.tsx
@@ -26,15 +26,16 @@ export const ContextOverlay = ({
     className = "",
     ...restProps
 }: ContextOverlayProps) => {
+    const portalClassNameFinal =
+        (preventTopPosition ? `${eccgui}-contextoverlay__portal--lowertop` : "") +
+        (portalClassName ? ` ${portalClassName}` : "");
+
     return (
         <BlueprintPopover
             placement="bottom"
             {...restProps}
             className={`${eccgui}-contextoverlay` + (className ? ` ${className}` : "")}
-            portalClassName={
-                (preventTopPosition ? `${eccgui}-contextoverlay__portal--lowertop` : "") +
-                (portalClassName ? ` ${portalClassName}` : "")
-            }
+            portalClassName={portalClassNameFinal.trim() ?? undefined}
         >
             {children}
         </BlueprintPopover>