Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve performance when creating Reaper automation points #250

Closed
wants to merge 1 commit into from

Conversation

carmethene
Copy link
Contributor

See: Reaper API - InsertEnvelopePoint

InsertEnvelopePoint()'s sort control flag works opposite to the way you'd expect. Flipping this code around prevents Reaper from re-sorting the automation curve for each point added, which significantly reduces import time.

See: https://www.reaper.fm/sdk/reascript/reascripthelp.html#InsertEnvelopePoint
InsertEnvelopePoint()'s sort control flag works opposite to the way you'd expect.  Flipping this code around prevents Reaper from re-sorting the automation curve for each point added, which significantly reduces execution time.
@firthm01
Copy link
Contributor

firthm01 commented Sep 14, 2023

Good spot! Looks good to me.
I've just created a rebased version in #252 to ensure CI runs and passes tests (main had a fix for the failing runners)

@firthm01 firthm01 closed this Sep 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants