Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Entries plot #825

Open
wants to merge 18 commits into
base: main
Choose a base branch
from
Open

Entries plot #825

wants to merge 18 commits into from

Conversation

dlrice
Copy link
Contributor

@dlrice dlrice commented Oct 29, 2024

Note

This should only deployed once backend have populated the table with all of the historical releases.

Purpose

Create plot of growth of swiss-prot / trembl

Approach

  • Use D3 and copy approach used in the other stats plots.
  • Created new DefaultDict util fn à la python's to facilitate accumulating values when using a js object.
  • Updated the PR checklist.

Testing

Wrote a unit test for the new DefaultDict util fn.

Checklist

  • My PR is scoped properly, and “does one thing only”
  • I have reviewed my own code
  • I have checked that linting checks pass and type safety is respected
  • I have checked that tests pass and coverage has at least improved, and if not explained the reasons why

Copy link
Contributor

@aurel-l aurel-l left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small changes here and there to generate a view that I prefer visually, but it's up to you to decide if you want it or not
Screenshot 2024-11-11 at 18 38 56
This is the resulting view with the changes in this review.
Feel free to just pick and choose the changes that you prefer

package.json Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants