Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Edit output path to root instead of bin folder #11

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

KevinLamb
Copy link

@KevinLamb KevinLamb commented Jun 22, 2018

Couldn't run due to an error on line 34 of WordPOSTagger.cs related to the ModelPath being set with AppDomain.CurrentDomain.BaseDirectory. AppDomain.CurrentDomain.BaseDirectory was returning the bin folder instead of the application root.

Edit: I plan on trying out a couple loggers after this.

@rohitshubham
Copy link
Member

Perfect! Thanks for taking a look at this. I plan on going through this change at some point over this weekend. 👍

@eigenharsha eigenharsha added the bug Something isn't working label Jun 24, 2018
@eigenharsha
Copy link
Member

eigenharsha commented Jun 24, 2018

@KevinLamb Thanks for looking into this, We can try to stay with the default .Net configuration structure, it will ease to other developers, they will get a solution to the output directory as default.

$(SolutionDir)bin\Debug or $(SolutionDir)bin\Release

For path issue, can we go through other options?

AppDomain.BaseDirectory Property

@KevinLamb
Copy link
Author

@eigenharsha Yep, that makes sense. I made another commit that simply changed the ModelPath variables to point two directories up. If it's planned that this gets used in ASP.NET apps then we'd need to change it. AppDomain.CurrentDomain.BaseDirectory returns the root folder instead of the Debug or Release folder for ASP.NET applications.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants