fix GAM issues

NEWS.md

@@ -11,6 +11,10 @@
 - `plot()` for `simulate_parameters()` now better copes with models that have
   multiple response levels (e.g. multinomial models).
 
+## Bug fixes
+
+- Fixed issue in `plot()` for `parameters::model_parameters()` for GAM models.
+
 # see 0.9.0
 
 ## Changes

R/plot.parameters_model.R

@@ -53,6 +53,15 @@ plot.see_parameters_model <- function(x,
   # retrieve settings ----------------
   model_attributes <- attributes(x)[!names(attributes(x)) %in% c("names", "row.names", "class")]
 
+  # for GAMs, remove smooth terms
+  if (!is.null(x$Component) && any(x$Component == "smooth_terms")) {
+    x <- x[x$Component != "smooth_terms", ]
+    # if we only have one component left, remove Component column
+    if (insight::n_unique(x$Component) == 1) {
+      x$Component <- NULL
+    }
+  }
+
   # user wants to plot random effects (group levels)?
   if (isFALSE(model_attributes$ignore_group) &&
       isTRUE(model_attributes$mixed_model) &&
@@ -366,7 +375,7 @@ plot.see_parameters_model <- function(x,
     x$CI <- as.character(x$CI)
 
     x$group <- factor(x$Coefficient < y_intercept, levels = c(FALSE, TRUE))
-    if (all(x$group == "TRUE")) {
+    if (all(x$group == "TRUE", na.rm = TRUE)) {
       color_scale <- scale_color_material(reverse = TRUE)
     } else {
       color_scale <- scale_color_material()
@@ -401,7 +410,7 @@ plot.see_parameters_model <- function(x,
   } else {
     # plot setup for regular model parameters
     x$group <- factor(x$Coefficient < y_intercept, levels = c(FALSE, TRUE))
-    if (all(x$group == "TRUE")) {
+    if (all(x$group == "TRUE", na.rm = TRUE)) {
       color_scale <- scale_color_material(reverse = TRUE)
     } else {
       color_scale <- scale_color_material()

tests/testthat/test-plot.parameters_model.R

@@ -69,7 +69,7 @@ test_that("`plot.see_parameters_model()` random parameters works", {
   data(sleepstudy, package = "lme4")
 
   set.seed(12345)
-  sleepstudy$grp <- sample(1:5, size = 180, replace = TRUE)
+  sleepstudy$grp <- sample.int(5, size = 180, replace = TRUE)
   model <- lme4::lmer(
     Reaction ~ Days + (1 | grp) + (1 | Subject),
     data = sleepstudy
@@ -80,3 +80,18 @@ test_that("`plot.see_parameters_model()` random parameters works", {
     fig = plot(out)
   )
 })
+
+
+test_that("`plot.see_parameters_model()` random parameters works", {
+  skip_if_not_installed("vdiffr")
+  skip_if_not_installed("mgcv")
+  skip_if_not_installed("parameters")
+
+  data(mtcars)
+  m <- mgcv::gam(mpg ~ s(wt) + cyl + gear + disp, data = mtcars)
+  result <- parameters::model_parameters(m)
+  vdiffr::expect_doppelganger(
+    title = "plot.model_parameters_gam",
+    fig = plot(result)
+  )
+})