-
-
Notifications
You must be signed in to change notification settings - Fork 94
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding r2_mlm()
and possible update to r2()
to work with it
#764
Conversation
Merge branch 'master' of github.com:jluchman/performance # Conflicts: # inst/WORDLIST
what I consider is the opposite: running |
…edits; minor documentation edit
Update just pushed that incorporates the |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #764 +/- ##
==========================================
- Coverage 58.52% 58.47% -0.05%
==========================================
Files 88 89 +1
Lines 6597 6623 +26
==========================================
+ Hits 3861 3873 +12
- Misses 2736 2750 +14 ☔ View full report in Codecov by Sentry. |
Thanks a lot, looks good to me! |
Fixes #758
This pull request includes a new function$R^2$ values for multivariate linear regression objects/objects of class
r2_mlm()
that generates twoc("mlm", "lm")
and is associated with issue #758.This pull request also adds an$R^2$ metric separated by response. I see value in this addition to the
multivariate
logical argument to ther2()
function for its "mlm" S3 method that can invoke the computation of ther2_mlm
but is by default 'off'/FALSE
and returns the currentr2()
function but do understand if it is not in the spirit of the function and it is not deemed a value add.