Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JOSE paper #586

Merged
merged 43 commits into from
Oct 5, 2023
Merged

JOSE paper #586

merged 43 commits into from
Oct 5, 2023

Conversation

rempsyc
Copy link
Member

@rempsyc rempsyc commented May 13, 2023

Preparing to submit to JOSE

Real time PDF: https://github.com/easystats/performance/blob/JOSE_paper/papers/JOSE/paper.pdf

Edit: reminder to use [skip ci] in this PR

Follow-up on #568

@codecov-commenter
Copy link

codecov-commenter commented May 13, 2023

Codecov Report

Merging #586 (ba4fa05) into main (4ec706e) will decrease coverage by 0.06%.
The diff coverage is n/a.

❗ Current head ba4fa05 differs from pull request most recent head c6d5115. Consider uploading reports for the commit c6d5115 to get more accurate results

@@            Coverage Diff             @@
##             main     #586      +/-   ##
==========================================
- Coverage   54.95%   54.90%   -0.06%     
==========================================
  Files          84       84              
  Lines        5852     5852              
==========================================
- Hits         3216     3213       -3     
- Misses       2636     2639       +3     

see 1 file with indirect coverage changes

@rempsyc
Copy link
Member Author

rempsyc commented May 14, 2023

I've tried submitting the JOSE paper yesterday, and again today, but I keep getting an error on submission ("something went wrong"). So I am not able to submit.

openjournals/jose#22

@rempsyc rempsyc requested a review from DominiqueMakowski May 14, 2023 20:38
@rempsyc
Copy link
Member Author

rempsyc commented Jun 7, 2023

Our paper now in prereview at openjournals/jose-reviews#211

@rempsyc
Copy link
Member Author

rempsyc commented Oct 4, 2023

@strengejacke reviewers have finished their review of the JOSE outliers paper. There is usually the checklist below to complete:

Additional Author Tasks After Review is Complete

  • Double check authors and affiliations (including ORCIDs)
  • Make a release of the software with the latest changes from the review and post the version number here. This is the version that will be used in the JOSS paper.
  • Archive the release on Zenodo/figshare/etc and post the DOI here.
  • Make sure that the title and author list (including ORCIDs) in the archive match those in the JOSS paper.
  • Make sure that the license listed for the archive is the same as the software license.

Which involves making a new release of the software and putting it on Zenodo. There is a bit of ambiguity relative to what exactly should be put on Zenodo, but usually it is the whole repository. Furthermore, it seems performance already has a Zenodo page with a specific doi, do you think I need to create a new one? Given that we use a branch here, I wonder if we need to merge first as well?

@rempsyc
Copy link
Member Author

rempsyc commented Oct 4, 2023

According to this Stack Overflow answer,

The documentation on the Zenodo homepage doesn't seem to explain this explicitly but the documentation on Github does: Zenodo creates releases from the releases on Github, so to update your entry on Zenodo, you need to create a new release on Github.

And I can see the performance Zenodo archive indeed seems up-to-date. So I think we only need to make a new release and provide that doi? But we probably need to merge first?


Edit: Actually let's wait to close #636 before merging Ready to merge 🙃

@rempsyc
Copy link
Member Author

rempsyc commented Oct 4, 2023

Congratulations everyone @mattansb, @IndrajeetPatil, @strengejacke, @bwiernik, and @DominiqueMakowski, our JOSE paper is basically accepted at this point and so now is the last time to check affiliations or make last minutes changes. The final version of the paper is available here (scroll down to download the artifact file): https://github.com/easystats/performance/actions/runs/6408158062

@bwiernik
Copy link
Contributor

bwiernik commented Oct 4, 2023

Thanks for all of your efforts!

@IndrajeetPatil
Copy link
Member

@rempsyc Woot!!! Thanks for all the hard work you put into this. Congrats! 🎉

@rempsyc rempsyc requested a review from strengejacke October 4, 2023 18:11
@rempsyc rempsyc merged commit 187ab58 into main Oct 5, 2023
25 checks passed
@rempsyc rempsyc deleted the JOSE_paper branch October 5, 2023 14:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants