Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #639 #640

Closed
wants to merge 2 commits into from
+4 −4
Closed

Fix #639 #640

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7b59cae
Fix #639
chainsawriot May 24, 2024
0a02ba1
OR doesn't use effectsize_type
chainsawriot May 24, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions R/eta_squared-main.R
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -833,7 +833,7 @@ cohens_f_squared <- function(model,
include_intercept = include_intercept
)

attr(out, "anova_type") <- tryCatch(attr(parameters::model_parameters(model, verbose = FALSE, effects = "fixed"), "anova_type"),
attr(out, "anova_type") <- tryCatch(attr(parameters::model_parameters(model, verbose = FALSE, effectsize_type = "fixed"), "anova_type"),
error = function(...) 1
)
attr(out, "approximate") <- TRUE
Expand Down Expand Up @@ -864,7 +864,7 @@ cohens_f_squared <- function(model,

# TODO this should be in .anova_es.anvoa
# TODO the aoc method should convert to an anova table, then pass to anova
params <- parameters::model_parameters(model, verbose = verbose, effects = "fixed")
params <- parameters::model_parameters(model, verbose = verbose, effectsize_type = "fixed")
out <- .es_aov_simple(as.data.frame(params),
type = type,
partial = partial, generalized = generalized,
Expand All @@ -890,7 +890,7 @@ cohens_f_squared <- function(model,
verbose = TRUE,
include_intercept = FALSE,
...) {
params <- parameters::model_parameters(model, verbose = verbose, effects = "fixed")
params <- parameters::model_parameters(model, verbose = verbose, effectsize_type = "fixed")
anova_type <- attr(params, "anova_type")
params <- as.data.frame(params)

Expand Down
2 changes: 1 addition & 1 deletion R/eta_squared-methods.R
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -255,7 +255,7 @@
ci = 0.95, alternative = "greater",
verbose = TRUE,
...) {
params <- parameters::model_parameters(model, verbose = verbose, effects = "fixed")
params <- parameters::model_parameters(model, verbose = verbose, effectsize_type = "fixed")
anova_type <- attr(params, "anova_type")

params <- split(params, factor(params$Response, levels = unique(params$Response))) # make sure row order is not changed
Expand Down